pluggable keystores #6069
Draft
pluggable keystores #6069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Mar 9, 2019
Stebalien
force-pushed
the
feat/pluggable-keystore
branch
from
89db07f to
b72a340
Compare
|
Oh snap this is awesome! 🎆 Let me try and integrate the keystore I wrote today and see if I come across any unexpected issues. |
bonedaddy
reviewed
Mar 10, 2019
repo/fsrepo/fsrepo.go
Outdated
| spec = map[string]interface{}{"type": "files", "path": "keystore"} | ||
| } | ||
|
|
||
| ksType, ok := spec["type"] |
There was a problem hiding this comment.
Experimenting with this locally gives me:
../../../../pkg/mod/github.com/ipfs/[email protected]/repo/fsrepo/fsrepo.go:397:25: cannot use ksType (type interface {}) as type string in map index: need type assertion
Might need to do ?
Suggested change
| ksType, ok := spec["type"] | |
| ksType, ok := spec["type"].(string) |
This patch allows keystores to be configured via the config and plugins. It's completely untested for now, but I started this so I figured I'd get it to a point where we could consider finishing it. License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
feat/pluggable-keystore
branch
from
9c97a9a to
ab644a0
Compare
|
ping @Stebalien what's the status of this and is this something we still want? |
Stebalien
added
status/inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows keystores to be configured via the config and plugins.
It's completely untested for now, but I started this so I figured I'd get it to a point where we could consider finishing it.
Depends on: ...
CC @postables