Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lowering for iree_attention custom op #17592

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add lowering for iree_attention custom op #17592

wants to merge 1 commit into from

Conversation

NatashaKnk
Copy link
Contributor

This PR is a follow-up for this PR in IREE-Jax in an effort to introduce a custom StableHLO attention op which lowers to the linalg_ext version.

@jpienaar
Copy link
Member

I think we could even land this first with local testing & then use that as part of testing in the other repo.

@NatashaKnk
Copy link
Contributor Author

By local testing, do you mean more extensive testing than exists here? Where should this be added if so?

@NatashaKnk NatashaKnk marked this pull request as ready for review June 25, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanhanW hanhanW Awaiting requested review from hanhanW hanhanW is a code owner

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@rsuderman rsuderman Awaiting requested review from rsuderman rsuderman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NatashaKnk @jpienaar