Fix for issue #3: create a stub class and singleton to represent main #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent the 'main' coro. __yield on that object will raise YieldFromMain.
|
r.e. unit test, is this what you're asking for? >>> import coro
>>> s = coro.tcp_sock()
>>> s.connect (('127.0.0.1', 80))
Segmentation fault: 11 |
markpeek
added a commit
to markpeek/shrapnel
that referenced
this pull request
Jul 21, 2014
This is an updated patch from pull request ironport#16 which will throw an exception if coro is called without starting the event_loop(). The main update is to bring it up to date with recent changes and make the linux poller throw the correct exception in this case.
markpeek
added a commit
that referenced
this pull request
Jul 23, 2014
This is an updated patch from pull request #16 which will throw an exception if coro is called without starting the event_loop(). The main update is to bring it up to date with recent changes and make the linux poller throw the correct exception in this case.
|
Fix merged and pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running with this change for a week or two now.
The main hazard is that some bit of Python code might assume that current() == None implies main.
This will no longer be true.