Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "pycrypto" as the required dependency #51

Merged
merged 1 commit into from
Oct 25, 2013

Conversation

atykhonov
Copy link
Contributor

No description provided.

@mkushnir
Copy link

This is a quick fix. But wouldn't it be better in the upstream shrapnel to replace Crypto.* in its ssh implementation with coro.ssl?

@atykhonov
Copy link
Contributor Author

Yes, this is a quick fix.
For now, this is a fact that shrapnel requires pycrypto. So I added it into the install_requires with hope that this will save someone else some time to figure out which exactly required dependency is missed..

@samrushing
Copy link
Member

Actually I prefer pycrypto over openssl. Openssl is an abomination that must be avoided at all cost.

samrushing added a commit that referenced this pull request Oct 25, 2013
Added "pycrypto" as the required dependency
@samrushing samrushing merged commit f9c1226 into ironport:master Oct 25, 2013
@mkushnir
Copy link

I'd be curious why openssl is in such a disfavor...

@samrushing
Copy link
Member

This is just my personal opinion, but openssl is the poster child for everything that is broken in the C language.
One of my biggest complaints is around pointer ownership, several of the API's use conflicting/confusing design for pointer ownership, and it's always full of surprises. Stopping openssl from leaking is a challenge.

One of my fantasy projects for Irken is to write a TLS library with a C API, where the fact that there's a GC is completely hidden from the end user, who would use a simple handle to represent ownership. Free the handle, and everything related to the connection goes away.,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants