I rethemed the website a bit #11
Conversation
I've decided to retheme the website (it is now dark mode in true dev fashion) At the moment it is using assets from a.thered.sh (my assets website), you could replace them though with your own if you don't trust my website lol
|
Hi sorry for the extremely late response. I shall speak to my team about it and will keep you posted |
|
This looks good. @is-a-dev/maintainers, what do you think? |
|
I like it, but the only thing is the website uses external assets/files. |
|
Good point @WilliamDavidHarrison, it'd be better if the css and the font files were served from here instead. |
index.html
Outdated
| <link rel="stylesheet" href="https://a.thered.sh/assets/fonts/Roboto/font.css"> | ||
| <link rel="stylesheet" href="https://a.thered.sh/assets/fonts/UbuntuMono/font.css"> | ||
| <link rel="stylesheet" href="https://a.thered.sh/assets/fa/css/all.min.css"> |
There was a problem hiding this comment.
It'll be better if all font and css files were served from this repo instead.
There was a problem hiding this comment.
It should be served from / instead for now, my repo has both fa and fonts there
There was a problem hiding this comment.
Update: no longer served from /, rather I use relative paths which actually work this time after too many commits lol
|
@phenax Can the maintainers team get push access so we can merge it once it is finished if you're not online? |
|
I'll be fixing this up, the fa/css/all.min.css is a css file linking to fontawesome, you need to include fontawesome in your thing to get it working, the fonts are pretty easy to import, I can set everything up, just give me a bit... |
in the process of moving assets to repository instead of a.thered.sh
|
i fixed it, there's also a deployed demo https://theredxd.github.io/is-a-dev.github.io/ |
|
Is Font Awesome hosted on CDNJS? That would be better than hosting it ourselves due to the amount of lines. |
|
Looks like it! |
fonts/Mangabey/LICENSE.txt
Outdated
There was a problem hiding this comment.
Please remove this file as it is not needed
fonts/Roboto/LICENSE.txt
Outdated
There was a problem hiding this comment.
Please remove this file as it is not needed
fonts/UbuntuMono/LICENSE.txt
Outdated
There was a problem hiding this comment.
Please remove this file as it is not needed
| </main> | ||
| </body> | ||
| </body> | ||
|
|
There was a problem hiding this comment.
It is licensing, generally you'd want to leave that in but ig I can remove it?
There was a problem hiding this comment.
@TheRedXD Half of the licenses are just blank and also they aren't referenced anywhere either. We can always add attribution in the footer.
Yes, I was asked to have it serve from the repo though |
|
@WilliamDavidHarrison Sorry for the delay, I've given write access to the maintainers team. |
|
@phenax All good. By the way, is there a faster way to contact you if needed like Telegram or something? Also, can you give them the top maintainer role on Discord? |
|
@WilliamDavidHarrison, email would be the most convinient. If it is something urgent, please mention |
I've decided to retheme the website (it is now dark mode in true dev fashion)
At the moment it is using assets from a.thered.sh (my assets website), you could replace them though with your own if you don't trust my website lol