Performance improvement by replacing "is" charclass lookups with context-specific functions #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is a continuation of the performance work started in #204.
Whilst splitting the
is
function into "charclass" vs RegExp versions provided a big improvement, the former of these remains the "hottest" function in this module. Here's what the V8 profiler says after processing ~25MB of XML:By further splitting
is
into context-specific functions, namelyisWhitespace
,isQuote
andisAttribEnd
, and replacing the Object lookups with conditional statements, I see a measurable improvement for the same task:The real-world performance gains of this change suggest a throughput improvement in the ~5-10% range.
Like last time, the existing and extensive test suite covers all the modified code paths and continues to pass after this change.