Skip to content

Commit

Permalink
Error message if constant not found.
Browse files Browse the repository at this point in the history
  • Loading branch information
askamkin committed Dec 29, 2020
1 parent 4b9563f commit e356056
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import ru.ispras.microtesk.translator.nml.ir.primitive.Instance;
import ru.ispras.microtesk.translator.nml.ir.primitive.Primitive;
import ru.ispras.microtesk.translator.nml.ir.primitive.PrimitiveAnd;
import ru.ispras.microtesk.translator.nml.ir.shared.LetConstant;
import ru.ispras.microtesk.translator.nml.ir.shared.MemoryResource;
import ru.ispras.microtesk.translator.nml.ir.shared.Struct;
import ru.ispras.microtesk.translator.nml.ir.shared.Type;
Expand Down Expand Up @@ -64,7 +65,14 @@ public Expr location(

// Hack to deal with internal variables described by string constants.
if (NmlSymbolKind.LET_CONST == kind) {
final Expr expr = getIr().getConstants().get(name).getExpr();
final LetConstant constant = getIr().getConstants().get(name);
if (null == constant) {
// Forward definition.
raiseError(where, String.format(
"Constant %s is not found. Forward definitions are not allowed.", name));
}

final Expr expr = constant.getExpr();
if (expr.isInternalVariable()) {
return new Expr(expr);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*
* Copyright 2020 ISP RAS (http://www.ispras.ru)
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/

package ru.ispras.microtesk.translator.nml;

import org.junit.Test;
import ru.ispras.microtesk.translator.TranslatorTest;
import ru.ispras.microtesk.translator.nml.ir.Ir;

public class LetForwardTestCase extends TranslatorTest<Ir> {

@Test
public void test() {
final NmlTranslator translator = new NmlTranslator();
translate(translator, "./src/test/nml/let_forward.nml");
}
}
2 changes: 2 additions & 0 deletions src/test/nml/let_forward.nml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
let CONST_1 = CONST_2 // ERROR: Forward definition.
let CONST_2 = 0x1

0 comments on commit e356056

Please sign in to comment.