add domain name for virtual host match in envoy filters

[ramaraochavali]

No description provided.

[howardjohn]

what is the use case for using this vs name? Does it do wildcards or only exact match (like can I have a wildcard here to match a wildcard domain)? Does it consider port (I think we configure envoy to ignore port?)?

[ramaraochavali]

The use case is - if we enable route collapse optimization with different domain names using same routes, we pick one route name and merge.

Yes. It can match wildcard names and port is not included.

[hzxuzhonghu]

When is the name not able to distinguish the VHost?

[ramaraochavali]

Actual Routes"

 {
     "version_info": "2024-11-01T23:45:05Z/17931",
     "route_config": {
      "@type": "type.googleapis.com/envoy.config.route.v3.RouteConfiguration",
      "name": "https.10443.xxxx",
      "virtual_hosts": [
       {
        "name": "*.au:10443",
        "domains": [
         "*.au"
        ],
        "routes": [..]
       },
       {
        "name": "*.com:10443",
        "domains": [
         "*.com",
         "*"
        ],
        "routes": [..]
       },
      ]
     }
}

after merge

     {
      "version_info": "2024-11-01T23:45:05Z/17931",
      "route_config": {
       "@type": "type.googleapis.com/envoy.config.route.v3.RouteConfiguration",
       "name": "https.10443.xxxx",
       "virtual_hosts": [
        {
         "name": "*.com:10443",
         "domains": [
          "*.au",
          "*.com",
         ],
         "routes": [..]
        }
       ]
      }

Now we can not match on Vs Host name

[howardjohn]

So in this case, i put match.domainName = "*.au"? And it will apply to *.com as well though?

[ramaraochavali]

I will add example. Release notes planning to add it for the implementation PR

[hzxuzhonghu]

Seems only me is still confusing, Isn't name already unique to distinguish the VirtualHost

I am not sure how https://github.com/istio/api/pull/3376/files#r1868857034 is related

[ramaraochavali]

it is not. When we have routes collapsed for different domains, we pick one virtual host and combine domains - So it is not possible to uniquely identify a virtual host by name for a domain.

[ramaraochavali]

@linsun added example. PTAL

[ramaraochavali]

@linsun can you PTAL when you get chance?