Move buffers package to internal, add some test coverage (uber-go#241)

Makefile

@@ -3,7 +3,7 @@ export GO15VENDOREXPERIMENT=1
 BENCH_FLAGS ?= -cpuprofile=cpu.pprof -memprofile=mem.pprof -benchmem
 PKGS ?= $(shell glide novendor)
 # Many Go tools take file globs or directories as arguments instead of packages.
-PKG_FILES ?= *.go zapcore buffers benchmarks testutils internal/exit
+PKG_FILES ?= *.go zapcore benchmarks testutils internal/buffers internal/exit
 
 # The linting tools evolve with each Go version, so run them only on the latest
 # stable release.

field.go

@@ -26,7 +26,7 @@ import (
 	"math"
 	"time"
 
-	"go.uber.org/zap/buffers"
+	"go.uber.org/zap/internal/buffers"
 	"go.uber.org/zap/zapcore"
 )
 

internal/buffers/buffers_test.go

@@ -0,0 +1,45 @@
+// Copyright (c) 2016 Uber Technologies, Inc.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+
+package buffers
+
+import (
+	"sync"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestBuffers(t *testing.T) {
+	var wg sync.WaitGroup
+	for g := 0; g < 10; g++ {
+		wg.Add(1)
+		go func() {
+			for i := 0; i < 100; i++ {
+				buf := Get()
+				assert.Zero(t, len(buf), "Expected truncated buffer")
+				assert.NotZero(t, cap(buf), "Expected non-zero capacity")
+				Put(buf)
+			}
+			wg.Done()
+		}()
+	}
+	wg.Wait()
+}

zapcore/entry.go

@@ -26,7 +26,7 @@ import (
 	"sync"
 	"time"
 
-	"go.uber.org/zap/buffers"
+	"go.uber.org/zap/internal/buffers"
 	"go.uber.org/zap/internal/exit"
 )