Merge pull request #620 from elliot-nelson/enelson/reporter

fix(fullReporter): Fix off-by-one display issue
ivogabe · Nov 10, 2019 · e006f9b · e006f9b
2 parents 9a3f8d0 + 4023a97
commit e006f9b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/reporter.ts b/lib/reporter.ts
@@ -132,7 +132,7 @@ export function fullReporter(fullFilename: boolean = false): Reporter {
 				const logLine = (lineIndex: number, errorStart: number, errorEnd?: number) => {
 					const line = lines[lineIndex];
 					if (errorEnd === undefined) errorEnd = line.length;
-					console.log('> ' + colors.gray('[' + lineIndex + '] ')
+					console.log('> ' + colors.gray('[' + (lineIndex + 1) + '] ')
 						+ line.substring(0, errorStart)
 						+ colors.red(line.substring(errorStart, errorEnd))
 						+ line.substring(errorEnd)
@@ -141,8 +141,8 @@ export function fullReporter(fullFilename: boolean = false): Reporter {
 
 				for (let i = error.startPosition.line; i <= error.endPosition.line; i++) {
 					logLine(i,
-						i === error.startPosition.line ? error.startPosition.character - 1 : 0,
-						i === error.endPosition.line ? error.endPosition.character - 1 : undefined
+						i === error.startPosition.line ? error.startPosition.character : 0,
+						i === error.endPosition.line ? error.endPosition.character : undefined
 					);
 				}
 			}

diff --git a/release/reporter.js b/release/reporter.js
@@ -91,13 +91,13 @@ function fullReporter(fullFilename = false) {
                     const line = lines[lineIndex];
                     if (errorEnd === undefined)
                         errorEnd = line.length;
-                    console.log('> ' + colors.gray('[' + lineIndex + '] ')
+                    console.log('> ' + colors.gray('[' + (lineIndex + 1) + '] ')
                         + line.substring(0, errorStart)
                         + colors.red(line.substring(errorStart, errorEnd))
                         + line.substring(errorEnd));
                 };
                 for (let i = error.startPosition.line; i <= error.endPosition.line; i++) {
-                    logLine(i, i === error.startPosition.line ? error.startPosition.character - 1 : 0, i === error.endPosition.line ? error.endPosition.character - 1 : undefined);
+                    logLine(i, i === error.startPosition.line ? error.startPosition.character : 0, i === error.endPosition.line ? error.endPosition.character : undefined);
                 }
             }
         },