Allow resolving @types that name libraries in node_modules directories above cwd #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #563.
At first I thought the issue was merely due to the characteristics of the paths in the various configuration files, but the key is really whether the libraries that the TypeScript compiler needs to find are below or above its
cwd
. The problem happens when the libraries are abovecwd
.I don't think there is a safe way to manipulate the
cwd
of thegulp
process that is used to run the whole test suite. It is possible to change it, but changing it for one gulp task will affect other gulp tasks running in parallel. So I've added another type of test to the suite. If a test contains agulpfile.js
then this test is also deemed an "exec test" and the topgulpfile.js
will launch a newgulp
subprocess on the test's gulpfile. This is a pass/fail test: if the subprocess ends without error that's a pass.