-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially Completed prod, help needed #138
Conversation
Thanks a lot for the PR! I'll need to rebase this to the latest master branch before continuing. Could you please give me write access to the PR? 🙂 |
I directly added you as contributer on my fork. |
Thanks a lot for your contribution. I'll check it out in more detail soon. In the meantime, could you make sure the methods all follow the formatting explained in the contributor guide in the docs? I also go through some examples in the Array API tutorial series on YouTube. Essentially:
Please check the contributor guide in the docs for more details. Thanks! Additionally, it may be necessary to resolve new conflicts with master since the PR was made. As a guide for resolving conflicts with upstream, I have created this short YouTube series. Your PR may already be perfect, and if this is the case then no need to do anything! Some tests will be failing, and thus the X shown, this is fine, as long as the tests for your own function are passing. I'll take a look at the tests soon and see if it's ready to be merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reformat the code as describe in the contributor guide in the docs, and also as explained in this YouTube series.
Closing PR due to inactivity. |
Jax
Test Passed: 27, Ignored 69 of 96 tests
Torch
Test Failed: 12, passed: 42, Ignored 42 of 96 tests
Tensorflow
Test Failed: 36, passed: 36, Ignored 24 of 96 tests
the Error message in all of the failed tests:
E AttributeError: 'function' object has no attribute 'reduce'
Numpy
Test Failed: 33, passed: 33, Ignored 30 of 96 tests
the Error message in all of the failed tests:
E AttributeError: 'function' object has no attribute 'reduce'
Mxnet
Test Failed: 42, Ignored 54 of 96 tests
What can I do for 'reduce' error?