Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linalg] add cholesky api to ivy core and backends #79

Merged
merged 2 commits into from
Feb 13, 2022
Merged

[linalg] add cholesky api to ivy core and backends #79

merged 2 commits into from
Feb 13, 2022

Conversation

kvignesh1420
Copy link
Contributor

@kvignesh1420 kvignesh1420 commented Feb 11, 2022 •
edited
Loading

This PR adds the Cholesky decomposition method to ivy core.
Addresses the issue: #74

@kvignesh1420
Copy link
Contributor Author

cc: @djl11 I was testing the functionality using pytest test_array_api/array_api_tests/test_linalg.py::test_cholesky but encountered errors such as AssertionError: eye is not defined in ivy.functional.backends.numpy. A related commit would be: ae74f1c. Can you provide some insight on the test case design? Thanks!

@kvignesh1420 kvignesh1420 force-pushed the linalg-cholesky branch 2 times, most recently from 1bee14a to f303610 Compare February 11, 2022 20:49
@djl11
Copy link
Contributor

djl11 commented Feb 12, 2022 •
edited
Loading

Hi @kvignesh1420, for now don't worry about the unit tests in test_array_api. These tests are for our compliance with the Array API standard, but we are in the process of adding support for these tests incrementally. For now, the place to add linalg tests would be /ivy_tests/test_functional/test_core/test_linalg.py

@djl11
Copy link
Contributor

djl11 commented Feb 12, 2022

More generally, unit tests for any updates to the functional API should go in ivy_tests/test_functional

@kvignesh1420
Copy link
Contributor Author

Sure, will make the changes!

@kvignesh1420
Copy link
Contributor Author

@djl11 added the test. Please take a look!

@djl11 djl11 merged commit 88e4c8f into ivy-llc:master Feb 13, 2022
@djl11
Copy link
Contributor

djl11 commented Feb 13, 2022

Looks great, thanks @kvignesh1420 !

@kvignesh1420 kvignesh1420 deleted the linalg-cholesky branch February 13, 2022 21:08
Aaa2275 pushed a commit to Aaa2275/ivy that referenced this pull request Dec 2, 2022
@honno
Merge pull request ivy-llc#79 from honno/asarray
dfca243 
`xp.asarray()` testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvignesh1420 @djl11