Disallow selecting hidden items from script

Fixes hluk#785
iwillcodeu · Sep 10, 2017 · 3dbddc4 · 3dbddc4
1 parent ae63eb8
commit 3dbddc4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/gui/clipboardbrowser.h b/src/gui/clipboardbrowser.h
@@ -211,6 +211,11 @@ class ClipboardBrowser : public QListView
          */
         bool loadItems();
 
+        /**
+         * Return true only if row is filtered and should be hidden.
+         */
+        bool isFiltered(int row) const;
+
     public slots:
         /**
          * Save items to configuration.
@@ -321,8 +326,6 @@ class ClipboardBrowser : public QListView
     private:
         bool isLoaded() const;
 
-        bool isFiltered(int row) const;
-
         /**
          * Hide row if filtered out, otherwise show.
          * @return true only if hidden

diff --git a/src/scriptable/scriptableproxy.cpp b/src/scriptable/scriptableproxy.cpp
@@ -938,7 +938,7 @@ bool ScriptableProxy::selectItems(const QList<int> &items)
 
         for (int i : items) {
             const QModelIndex index = c->index(i);
-            if (index.isValid())
+            if ( index.isValid() && !c->isFiltered(i) )
                 c->selectionModel()->select(index, QItemSelectionModel::Select);
         }
     }