Skip to content

Commit

Permalink
master => main
Browse files Browse the repository at this point in the history
  • Loading branch information
jb3 committed Mar 13, 2021
1 parent 7bc390e commit a394c42
Show file tree
Hide file tree
Showing 10 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_run:
workflows: ["Lint & Test"]
branches:
- master
- main
types:
- completed

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_run:
workflows: ["Build"]
branches:
- master
- main
types:
- completed

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Lint & Test
on:
push:
branches:
- master
- main
pull_request:


Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sentry_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ name: Create Sentry release
on:
push:
branches:
- master
- main

jobs:
create_sentry_release:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@master
uses: actions/checkout@main

- name: Create a Sentry.io release
uses: tclindner/[email protected]
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Contributing to one of Our Projects

Our projects are open-source and are automatically deployed whenever commits are pushed to the `master` branch on each repository, so we've created a set of guidelines in order to keep everything clean and in working order.
Our projects are open-source and are automatically deployed whenever commits are pushed to the `main` branch on each repository, so we've created a set of guidelines in order to keep everything clean and in working order.

Note that contributions may be rejected on the basis of a contributor failing to follow these guidelines.

## Rules

1. **No force-pushes** or modifying the Git history in any way.
2. If you have direct access to the repository, **create a branch for your changes** and create a pull request for that branch. If not, create a branch on a fork of the repository and create a pull request from there.
* It's common practice for a repository to reject direct pushes to `master`, so make branching a habit!
* It's common practice for a repository to reject direct pushes to `main`, so make branching a habit!
* If PRing from your own fork, **ensure that "Allow edits from maintainers" is checked**. This gives permission for maintainers to commit changes directly to your fork, speeding up the review process.
3. **Adhere to the prevailing code style**, which we enforce using [`flake8`](http://flake8.pycqa.org/en/latest/index.html) and [`pre-commit`](https://pre-commit.com/).
* Run `flake8` and `pre-commit` against your code [**before** you push it](https://soundcloud.com/lemonsaurusrex/lint-before-you-push). Your commit will be rejected by the build server if it fails to lint.
Expand All @@ -18,7 +18,7 @@ Note that contributions may be rejected on the basis of a contributor failing to
* Avoid making minor commits for fixing typos or linting errors. Since you've already set up a `pre-commit` hook to run the linting pipeline before a commit, you shouldn't be committing linting issues anyway.
* A more in-depth guide to writing great commit messages can be found in Chris Beam's [*How to Write a Git Commit Message*](https://chris.beams.io/posts/git-commit/)
5. **Avoid frequent pushes to the main repository**. This goes for PRs opened against your fork as well. Our test build pipelines are triggered every time a push to the repository (or PR) is made. Try to batch your commits until you've finished working for that session, or you've reached a point where collaborators need your commits to continue their own work. This also provides you the opportunity to amend commits for minor changes rather than having to commit them on their own because you've already pushed.
* This includes merging master into your branch. Try to leave merging from master for after your PR passes review; a maintainer will bring your PR up to date before merging. Exceptions to this include: resolving merge conflicts, needing something that was pushed to master for your branch, or something was pushed to master that could potentionally affect the functionality of what you're writing.
* This includes merging main into your branch. Try to leave merging from main for after your PR passes review; a maintainer will bring your PR up to date before merging. Exceptions to this include: resolving merge conflicts, needing something that was pushed to main for your branch, or something was pushed to main that could potentionally affect the functionality of what you're writing.
6. **Don't fight the framework**. Every framework has its flaws, but the frameworks we've picked out have been carefully chosen for their particular merits. If you can avoid it, please resist reimplementing swathes of framework logic - the work has already been done for you!
7. If someone is working on an issue or pull request, **do not open your own pull request for the same task**. Instead, collaborate with the author(s) of the existing pull request. Duplicate PRs opened without communicating with the other author(s) and/or PyDis staff will be closed. Communication is key, and there's no point in two separate implementations of the same thing.
* One option is to fork the other contributor's repository and submit your changes to their branch with your own pull request. We suggest following these guidelines when interacting with their repository as well.
Expand Down
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ and other tools to help keep the server running like a well-oiled machine.

Read the [Contributing Guide](https://pythondiscord.com/pages/contributing/bot/) on our website if you're interested in helping out.

[1]: https://github.com/python-discord/bot/workflows/Lint%20&%20Test/badge.svg?branch=master
[2]: https://github.com/python-discord/bot/actions?query=workflow%3A%22Lint+%26+Test%22+branch%3Amaster
[3]: https://github.com/python-discord/bot/workflows/Build/badge.svg?branch=master
[4]: https://github.com/python-discord/bot/actions?query=workflow%3ABuild+branch%3Amaster
[5]: https://github.com/python-discord/bot/workflows/Deploy/badge.svg?branch=master
[6]: https://github.com/python-discord/bot/actions?query=workflow%3ADeploy+branch%3Amaster
[7]: https://raw.githubusercontent.com/python-discord/branding/master/logos/badge/badge_github.svg
[1]: https://github.com/python-discord/bot/workflows/Lint%20&%20Test/badge.svg?branch=main
[2]: https://github.com/python-discord/bot/actions?query=workflow%3A%22Lint+%26+Test%22+branch%3Amain
[3]: https://github.com/python-discord/bot/workflows/Build/badge.svg?branch=main
[4]: https://github.com/python-discord/bot/actions?query=workflow%3ABuild+branch%3Amain
[5]: https://github.com/python-discord/bot/workflows/Deploy/badge.svg?branch=main
[6]: https://github.com/python-discord/bot/actions?query=workflow%3ADeploy+branch%3Amain
[7]: https://raw.githubusercontent.com/python-discord/branding/main/logos/badge/badge_github.svg
[8]: https://discord.gg/python
2 changes: 1 addition & 1 deletion bot/exts/backend/branding/_constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class AssetType(Enum):

BRANDING_URL = "https://api.github.com/repos/python-discord/branding/contents"

PARAMS = {"ref": "master"} # Target branch
PARAMS = {"ref": "main"} # Target branch
HEADERS = {"Accept": "application/vnd.github.v3+json"} # Ensure we use API v3

# A GitHub token is not necessary for the cog to operate,
Expand Down
2 changes: 1 addition & 1 deletion bot/exts/backend/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ async def startup_greeting(self) -> None:
url="https://github.com/python-discord/bot",
icon_url=(
"https://raw.githubusercontent.com/"
"python-discord/branding/master/logos/logo_circle/logo_circle_large.png"
"python-discord/branding/main/logos/logo_circle/logo_circle_large.png"
)
)

Expand Down
2 changes: 1 addition & 1 deletion bot/exts/info/source.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def get_source_link(self, source_item: SourceType) -> Tuple[str, str, Optional[i
else:
file_location = Path(filename).relative_to(Path.cwd()).as_posix()

url = f"{URLs.github_bot_repo}/blob/master/{file_location}{lines_extension}"
url = f"{URLs.github_bot_repo}/blob/main/{file_location}{lines_extension}"

return url, file_location, first_line_no or None

Expand Down
8 changes: 4 additions & 4 deletions config-default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ style:

filtering: "https://cdn.discordapp.com/emojis/472472638594482195.png"

green_checkmark: "https://raw.githubusercontent.com/python-discord/branding/master/icons/checkmark/green-checkmark-dist.png"
green_questionmark: "https://raw.githubusercontent.com/python-discord/branding/master/icons/checkmark/green-question-mark-dist.png"
green_checkmark: "https://raw.githubusercontent.com/python-discord/branding/main/icons/checkmark/green-checkmark-dist.png"
green_questionmark: "https://raw.githubusercontent.com/python-discord/branding/main/icons/checkmark/green-question-mark-dist.png"
guild_update: "https://cdn.discordapp.com/emojis/469954765141442561.png"

hash_blurple: "https://cdn.discordapp.com/emojis/469950142942806017.png"
Expand Down Expand Up @@ -360,8 +360,8 @@ urls:
discord_api: &DISCORD_API "https://discordapp.com/api/v7/"
discord_invite_api: !JOIN [*DISCORD_API, "invites"]

# Misc URLs
bot_avatar: "https://raw.githubusercontent.com/discord-python/branding/master/logos/logo_circle/logo_circle.png"
# Misc URLsw
bot_avatar: "https://raw.githubusercontent.com/python-discord/branding/main/logos/logo_circle/logo_circle.png"
github_bot_repo: "https://github.com/python-discord/bot"


Expand Down

0 comments on commit a394c42

Please sign in to comment.