fix(aliases): Fix wikilink resolution for aliases #1681
+30
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necauqua
force-pushed
the
alias-resolution-fix
branch
2 times, most recently
from
5b66ac8 to
5122560
Compare
necauqua
added a commit
to necauqua/quartz
that referenced
this pull request
Jan 4, 2025
Backlink calculation is quadratic, similar to breadcrumbs before the fix. Apply a similar fix here. Also added alias resolution, so this depends on `file.data.aliases` from jackyzha0#1681, but that can be commented out easily if needed.
aarnphm
reviewed
Jan 6, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
reviewed
Jan 7, 2025
aarnphm
approved these changes
Jan 7, 2025
necauqua
force-pushed
the
alias-resolution-fix
branch
from
5122560 to
5bcf67d
Compare
With markdownLinkResolution: "shortest", aka "+/- how Obsidian does it" and given pages A and nested/B which has an alias Z, if you try to link from A using [[Z]] it wouldn't work and get 404. This is caused by alias slugs (nested/Z in this case, emitted by AliasRedirects) not being present in the `allSlugs` list which is used by the link transformer. The fix is to compute the alias slugs in the frontmatter transformer and add them to `allSlugs` there. Also we store them in file data to avoid recomputing them when emitting alias redirect pages. Fixes jackyzha0#904 Note: given how currently the markdown/html transformers are ordered this doesn't really work. Given pages A and nested/B which has an alias Z, here's the order which currently happens: md-transformers(A) => html-transformers(A) => md-transformers(B) => html-transformers(B) Since the nested/Z slug will get added when md-transformers(B) are run, but the slugs are used by html-transformers(A) when resolving it's links - the link [[Z]] in A will still 404 A fix for this is to split the parser into two stages - first apply the md-transformers to all files, and only then apply html-transformers to all files. I did just that in a different commit, which is needed for this one to work correctly.
necauqua
force-pushed
the
alias-resolution-fix
branch
from
5bcf67d to
32b95a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With markdownLinkResolution: "shortest", aka "+/- how Obsidian does it" and given pages A and nested/B which has an alias Z, if you try to link from A using [[Z]] it wouldn't work and get 404.
This is caused by alias slugs (nested/Z in this case, emitted by AliasRedirects) not being present in the
allSlugslist which is used by the link transformer.The fix is to compute the alias slugs in the frontmatter transformer and add them to
allSlugsthere.Also we store them in file data to avoid recomputing them when emitting alias redirect pages.
Fixes #904
Note: given how currently the markdown/html transformers are ordered this doesn't really work.
Given pages A and nested/B which has an alias Z, here's the order which currently happens:
md-transformers(A) => html-transformers(A) =>
md-transformers(B) => html-transformers(B)
Since the nested/Z slug will get added when md-transformers(B) are run, but the slugs are used by html-transformers(A) when resolving it's links - the link [[Z]] in A will still 404
A fix for this is to split the parser into two stages - first apply the md-transformers to all files, and only then apply html-transformers to all files.
I did just that in a different commit, which is needed for this one to work correctly.
Depends on #1675