Fixes #124: Requires path separator in basepath #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making sure the common path ends with a path separator, we know we end up with an actual valid base path.
|
Hi, would you mind having a look at the failing test? |
|
@jacobrask The tests seem to fail due to something completely unrelated to my changes. The minimatch dependency seems to be the culprit here. I would suggest testing against Node v0.10 only (which succeeds), but you probably have your reasons for including old versions as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making sure the common path ends with a path separator, we know we end up with an actual valid base path.