Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some emojis to notifications #338

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Add some emojis to notifications #338

merged 2 commits into from
Aug 6, 2024

Conversation

ldab
Copy link
Collaborator

@ldab ldab commented Aug 6, 2024

Add some emojis to the notification app, it was not possible to add all the emojis as it consumes too much memory. Basically added faces, hand and ⌚

It works for iOS as it seems ANCS send the UTF-8 of the emoji, it seems like gadgetbridge does some pre-processing, need to check if it can be disabled.

I.e:

IMG_0719

@Kampi
Copy link
Collaborator

Kampi commented Aug 6, 2024

Is it possible to move them to the external flash for newer hardware revisions?

@jakkra
Copy link
Owner

jakkra commented Aug 6, 2024

Is it possible to move them to the external flash for newer hardware revisions?

Yes,

Is it possible to move them to the external flash for newer hardware revisions?

Yes, will be part of the same change to allow fonts in external flash. But that's another task. Part of it we move this too and can have all emoji.

@jakkra
Copy link
Owner

jakkra commented Aug 6, 2024

Can't we keep using same Montserrat font, but set this emoji font ass the fallback font. I think there is a function for the label to set fallback font? So if it's not found in Montserrat, it will search emoji font.

@ldab
Copy link
Collaborator Author

ldab commented Aug 6, 2024

Can't we keep using same Montserrat font, but set this emoji font ass the fallback font. I think there is a function for the label to set fallback font? So if it's not found in Montserrat, it will search emoji font.

this is somewhat set in the font itself: https://github.com/ldab/ZSWatch/blob/ac135bf6e1bc004d03f0f70c774933b2a1c036ba/app/src/images/fonts/noto_emoji_14_light.c#L1598

@ldab
Copy link
Collaborator Author

ldab commented Aug 6, 2024

@jakkra
Copy link
Owner

jakkra commented Aug 6, 2024

Can't we keep using same Montserrat font, but set this emoji font ass the fallback font. I think there is a function for the label to set fallback font? So if it's not found in Montserrat, it will search emoji font.

this is somewhat set in the font itself: https://github.com/ldab/ZSWatch/blob/ac135bf6e1bc004d03f0f70c774933b2a1c036ba/app/src/images/fonts/noto_emoji_14_light.c#L1598

Ah so the font is actually Montserrat, but with noto emoji. Maybe just change the font name then to reflect that.

@ldab
Copy link
Collaborator Author

ldab commented Aug 6, 2024

how bout that? added the emoji as a fallback from Montserrat, it was a const so didn't want to play around to modify it.... it is a bit hidden but it still works.

@ldab ldab requested a review from jakkra August 6, 2024 12:23
@jakkra
Copy link
Owner

jakkra commented Aug 6, 2024

Very nice, we can merge and then I'll figure out how to get gadgetbridge not convert it and let it stay utf-8

@ldab ldab merged commit de8d68b into jakkra:main Aug 6, 2024
13 checks passed
@ldab ldab deleted the show-emoji branch August 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants