-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some emojis to notifications #338
Conversation
Is it possible to move them to the external flash for newer hardware revisions? |
Yes,
Yes, will be part of the same change to allow fonts in external flash. But that's another task. Part of it we move this too and can have all emoji. |
Can't we keep using same Montserrat font, but set this emoji font ass the fallback font. I think there is a function for the label to set fallback font? So if it's not found in Montserrat, it will search emoji font. |
this is somewhat set in the font itself: https://github.com/ldab/ZSWatch/blob/ac135bf6e1bc004d03f0f70c774933b2a1c036ba/app/src/images/fonts/noto_emoji_14_light.c#L1598 |
and also here https://docs.lvgl.io/8.2/overview/font.html?highlight=fallback#use-font-fallback I'll do that |
Ah so the font is actually Montserrat, but with noto emoji. Maybe just change the font name then to reflect that. |
how bout that? added the emoji as a fallback from Montserrat, it was a const so didn't want to play around to modify it.... it is a bit hidden but it still works. |
Very nice, we can merge and then I'll figure out how to get gadgetbridge not convert it and let it stay utf-8 |
Add some emojis to the notification app, it was not possible to add all the emojis as it consumes too much memory. Basically added faces, hand and ⌚
It works for iOS as it seems ANCS send the UTF-8 of the emoji, it seems like gadgetbridge does some pre-processing, need to check if it can be disabled.
I.e: