This repository has been archived by the owner on Sep 11, 2021. It is now read-only.
Implemented mouse wheel handling and fixed click handling #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignoring GDK_2/3BUTTON_PRESS events to avoid clicks being handled multiple times
src/classes/window/presentation.vala
src/classes/window/presenter.vala
added functions to handle mousewheel scrolling: UP/LEFT for previous slide, DOWN/RIGHT for next
This implementation should be considered a hack for now. It has to be refactored in the future. For example if you start your presentation timer early by pressing one of the navigation keys during a countdown is running you are not able to go back into the countdown mode by pressing POS1 for example.
Last slide, one of the first 10, etc.
Removed deprecated call to poppler_page_render_to_pixbuf and substituted with poppler_page_render. First time I work with vala and poppler. As far as I can see (and test) it works, but I cannot guarantee it for all the cases ;-)
Not functional yet
Solved with a small hack, I could not get int? options to work...
Conflicts: src/pdf_presenter_console.vala
Due to pdf_link trying to get a slide past the limit
Missing: - Storing the edited notes in a file - Controlling mouse events
Note: I think there is a bug in vala/glib/whatever and it always adds a new line at the end of the notes file. Probably is not critical, but after many edits you should check your notes file!
From just # to ###
Not sure if this is a bug or if I'm missing some concept. However it now seems to work.
Conflicts: src/classes/presentation_controller.vala src/classes/window/presenter.vala src/pdf_presenter_console.vala Also automatically save the notes on (clean) exit
Probably a more robust behaviour
Conflicts: src/classes/presentation_controller.vala resolved conflicts
githubnemo
pushed a commit
to githubnemo/Pdf-Presenter-Console
that referenced
this pull request
Dec 23, 2015
See pull request jakobwesthoff#22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next time, my commit messages will not contain file names such that they are properly displayed in GitHub. Lesson learned ;)