Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filter bug #14

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Fixed filter bug #14

merged 6 commits into from
Oct 22, 2024

Conversation

chachacollins
Copy link
Contributor

Changes

  • Added type assertion to ensure selected item is always of valid type before beginning execution of logic .
  • fixed crashes that were caused by filtered values as your previous code ignored it leading to crashes when trying to filter because it expected type of cmd.Command item but filtered value is of a type string.
  • If the operation fails the program no longer crashes but just ignores the value provided to the filter.

@jalpp jalpp merged commit 1c105f8 into jalpp:dev Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants