starlark: disable int optimization in iOS, which doesn't support mmap (…

…google#291) Fixes google#290
jammiess · Jul 6, 2020 · 5d2ea04 · 5d2ea04
1 parent f5d7f27
commit 5d2ea04
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/starlark/int_generic.go b/starlark/int_generic.go
@@ -1,4 +1,4 @@
-//+build !linux,!darwin !amd64,!arm64,!mips64x,!ppc64x
+//+build !linux,!darwin darwin,arm64 !amd64,!arm64,!mips64x,!ppc64x
 
 package starlark
 

diff --git a/starlark/int_posix64.go b/starlark/int_posix64.go
@@ -1,5 +1,5 @@
 //+build linux darwin
-//+build amd64 arm64 mips64x ppc64x
+//+build amd64 arm64,!darwin mips64x ppc64x
 
 package starlark
 
@@ -10,6 +10,14 @@ package starlark
 // values be represented as an unsafe.Pointer, so that Int-to-Value
 // interface conversion need not allocate.
 
+// Although iOS (arm64,darwin) claims to be a POSIX-compliant,
+// it limits each process to about 700MB of virtual address space,
+// which defeats the optimization.
+//
+// TODO(golang.org/issue/38485): darwin,arm64 may refer to macOS in the future.
+// Update this when there are distinct GOOS values for macOS, iOS, and other Apple
+// operating systems on arm64.
+
 import (
 	"log"
 	"math"