Refactor code

janjonas · Mar 9, 2018 · 53b97b3 · 53b97b3
1 parent 9c101eb
commit 53b97b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/diagrams/flowchart/flowRenderer.js b/src/diagrams/flowchart/flowRenderer.js
@@ -176,10 +176,8 @@ export const addEdges = function (edges, g) {
 
     if (typeof edge.interpolate !== 'undefined') {
       edgeData.lineInterpolate = edge.interpolate
-    } else {
-      if (typeof edges.defaultInterpolate !== 'undefined') {
-        edgeData.lineInterpolate = edges.defaultInterpolate
-      }
+    } else if (typeof edges.defaultInterpolate !== 'undefined') {
+      edgeData.lineInterpolate = edges.defaultInterpolate
     }
 
     if (typeof edge.text === 'undefined') {

diff --git a/todo.md b/todo.md
@@ -6,10 +6,9 @@
 - rewrite less code
 - Setup code coverage
 - Create a desktop client
-- Fix flowchart interpolate/curve issue
-    - not a common feature so dist/index.html cannot reproduce this issue
 - Support customization of gantt diagram xAxis format
     - https://github.com/d3/d3-time-format#api-reference
     - https://bl.ocks.org/wboykinm/34627426d84f3242e0e6ecb2339e9065
 - Upgrade jasmine to latest version or replace it
 - Upgrade less to latest version or replace it
+- Flowchart interpolate is useless because there is no rendering code using it