Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow using theme in parent yak components together with .attrs #168

Merged
merged 7 commits into from
Oct 8, 2024
Merged

allow using theme in parent yak components together with .attrs #168

merged 7 commits into from
Oct 8, 2024

Conversation

jantimon
Copy link
Owner

@jantimon jantimon commented Oct 8, 2024

#163 introduced a bug where theme would not be passed to the parent yak component

@jantimon jantimon requested a review from Mad-Kat October 8, 2024 08:56
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #168 will not alter performance

Comparing fix-attrs (b191ae9) with main (dc4c420)

Summary

✅ 2 untouched benchmarks

@jantimon jantimon merged commit 945438e into main Oct 8, 2024
6 checks passed
@jantimon jantimon deleted the fix-attrs branch October 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mad-Kat Mad-Kat Awaiting requested review from Mad-Kat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jantimon