Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining jQuery from View tests #3073

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Remove remaining jQuery from View tests #3073

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
54b79e4
remove remaining jQuery from View tests
akre54 Mar 18, 2014
10c0b2e
use native CustomEvent constructor for DOM element
akre54 Mar 18, 2014
235fcc9
remove superfluous this from listento
akre54 Mar 19, 2014
93b3eb5
break out trigger shim
akre54 Mar 19, 2014
e4e5852
fix typo
akre54 Mar 19, 2014
9b2081f
shorter filterer fn with findWhere
akre54 Mar 19, 2014
ec57467
remove extra Backbone.$ checks
akre54 Mar 19, 2014
71ce73e
change back View -> Backbone.View
akre54 Mar 19, 2014
aecb76c
remove setup method
akre54 Mar 19, 2014
f724fa1
remove extra lines and small fixes
akre54 Mar 20, 2014
2efebb3
wrap custom events test in a Backbone.$ check
akre54 Apr 4, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove superfluous this from listento
  • Loading branch information
@akre54
akre54 committed Mar 23, 2014
commit 235fcc9ac8a88d17dafa642febddc83e8d6b7464
4 changes: 2 additions & 2 deletions test/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,8 @@
test("views stopListening", 0, function() {
var Test = View.extend({
initialize: function() {
this.listenTo(this.model, 'all x', function(){ ok(false); }, this);
this.listenTo(this.collection, 'all x', function(){ ok(false); }, this);
this.listenTo(this.model, 'all x', function(){ ok(false); });
this.listenTo(this.collection, 'all x', function(){ ok(false); });
}
});

Expand Down