Revert "Added reverse option in the collection sort method"

This reverts commit cea2f3f. Conflicts: backbone.js test/collection.js
jasonify · Apr 15, 2014 · ccdb757 · ccdb757
1 parent 285e07b
commit ccdb757
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/backbone.js b/backbone.js
@@ -870,8 +870,6 @@
         this.models.sort(_.bind(this.comparator, this));
       }
 
-      if (options.reverse) this.models = this.models.reverse();
-
       if (!options.silent) this.trigger('sort', this, options);
       return this;
     },

diff --git a/test/collection.js b/test/collection.js
@@ -284,23 +284,6 @@
     equal(col.indexOf(tom), 2);
   });
 
-  test("reverse sort with a sortBy stylecomparator", function() {
-    var col = new Backbone.Collection;
-    col.comparator = 'name';
-    var tom = col.add(new Backbone.Model({name: 'Tom'}));
-    var rob = col.add(new Backbone.Model({name: 'Rob'}));
-    var tim = col.add(new Backbone.Model({name: 'Tim'}));
-
-    equal(col.indexOf(rob), 0);
-    equal(col.indexOf(tim), 1);
-    equal(col.indexOf(tom), 2);
-
-    col.sort({reverse: true});
-    equal(col.indexOf(tom), 0);
-    equal(col.indexOf(tim), 1);
-    equal(col.indexOf(rob), 2);
-  });
-
   test("comparator that depends on `this`", 2, function() {
     var col = new Backbone.Collection;
     col.negative = function(num) {