forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
params: core, core/vm, miner: 64bit gas instructions
Reworked the EVM gas instructions to use 64bit integers rather than arbitrary size big ints. All gas operations, be it additions, multiplications or divisions, are checked and guarded against 64 bit integer overflows. In additon, most of the protocol paramaters in the params package have been converted to uint64 and are now constants rather than variables. * common/math: added overflow check ops * core: vmenv, env renamed to evm * eth, internal/ethapi, les: unmetered eth_call and cancel methods * core/vm: implemented big.Int pool for evm instructions * core/vm: unexported intPool methods & verification methods * core/vm: added memoryGasCost overflow check and test
- Loading branch information
Showing
47 changed files
with
1,087 additions
and
826 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package math | ||
|
||
import gmath "math" | ||
|
||
/* | ||
* NOTE: The following methods need to be optimised using either bit checking or asm | ||
*/ | ||
|
||
// SafeSub returns subtraction result and whether overflow occurred. | ||
func SafeSub(x, y uint64) (uint64, bool) { | ||
return x - y, x < y | ||
} | ||
|
||
// SafeAdd returns the result and whether overflow occurred. | ||
func SafeAdd(x, y uint64) (uint64, bool) { | ||
return x + y, y > gmath.MaxUint64-x | ||
} | ||
|
||
// SafeMul returns multiplication result and whether overflow occurred. | ||
func SafeMul(x, y uint64) (uint64, bool) { | ||
if x == 0 { | ||
return 0, false | ||
} | ||
return x * y, x != 0 && y != 0 && y > gmath.MaxUint64/x | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package math | ||
|
||
import ( | ||
gmath "math" | ||
"testing" | ||
) | ||
|
||
type operation byte | ||
|
||
const ( | ||
sub operation = iota | ||
add | ||
mul | ||
) | ||
|
||
func TestOverflow(t *testing.T) { | ||
for i, test := range []struct { | ||
x uint64 | ||
y uint64 | ||
overflow bool | ||
op operation | ||
}{ | ||
// add operations | ||
{gmath.MaxUint64, 1, true, add}, | ||
{gmath.MaxUint64 - 1, 1, false, add}, | ||
|
||
// sub operations | ||
{0, 1, true, sub}, | ||
{0, 0, false, sub}, | ||
|
||
// mul operations | ||
{10, 10, false, mul}, | ||
{gmath.MaxUint64, 2, true, mul}, | ||
{gmath.MaxUint64, 1, false, mul}, | ||
} { | ||
var overflows bool | ||
switch test.op { | ||
case sub: | ||
_, overflows = SafeSub(test.x, test.y) | ||
case add: | ||
_, overflows = SafeAdd(test.x, test.y) | ||
case mul: | ||
_, overflows = SafeMul(test.x, test.y) | ||
} | ||
|
||
if test.overflow != overflows { | ||
t.Errorf("%d failed. Expected test to be %v, got %v", i, test.overflow, overflows) | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.