Add sknobs_prepend #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuascheid
requested changes
Jan 10, 2022
| @@ -13,10 +13,12 @@ sknobs.init(sys.argv) | |||
| sknobs.set_value('abc', 4) | |||
| sknobs.set_string('xyz', 'there') | |||
| sknobs.add('ttt', 'tttvalue') | |||
| sknobs.add('ttt', 'pre_tttvalue') | |||
There was a problem hiding this comment.
Did you intend "prepend" here?
| @@ -12,6 +12,7 @@ extern int sknobs_init(int argc, char **argv); | |||
| extern void sknobs_close(void); | |||
|
|
|||
| extern int sknobs_add(char *pattern, char *value, char *comment); | |||
| extern int sknobs_prepend(char *pattern, char *value, char *comment); | |||
There was a problem hiding this comment.
Is the associated sknobs.c implementation missing from this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With VCS the library includes are order dependent. We need the ability to ensure certain knobs are set before others.
This patch introduces 'sknobs.prepend' which pushes knobs onto the head of the linked-list instead of the tail.