JBEAP-28797 Fix exception handling in WebappLifecycleListener.requestDestroyed() #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream Mojarra ticket and PRs: eclipse-ee4j/mojarra#5556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/JBEAP-28797
Upstream issue: TBD
Upstream PR: TBD
The exception handling in WebappLifecycleListener.requestDestroyed() is not working because the InitFacesContext doesn't have the getExceptionHandler() method implemented.
Checking upstream mojarra master the method has been implemented there: https://github.com/eclipse-ee4j/mojarra/blame/master/impl/src/main/java/com/sun/faces/config/InitFacesContext.java#L103
although that implementation is still not sufficient for this use case (we would need InitFacesContext to keep returning the same ExceptionHandler instance, rather than always creating a new instance).
So if this change looks reasonable I would follow up with upstream Mojarra tickets to fix the use case there as well.
BTW I don't know which branch to target with this PR, but EAP 7.4 is currently using 2.3.14.SP07, hence using 2.3.14.SP.
Cc @jasondlee