Skip to content

Commit

Permalink
Remove parser in the constructor of statics3 firehose as it is no lon…
Browse files Browse the repository at this point in the history
…ger needed with the new ingestion schemas
  • Loading branch information
nicktate authored and fjy committed Jan 20, 2015
1 parent 91a79db commit dd9b646
Showing 1 changed file with 1 addition and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,31 +56,22 @@ public class StaticS3FirehoseFactory implements FirehoseFactory<StringInputRowPa
private static final Logger log = new Logger(StaticS3FirehoseFactory.class);

private final RestS3Service s3Client;
private final StringInputRowParser parser;
private final List<URI> uris;

@JsonCreator
public StaticS3FirehoseFactory(
@JacksonInject("s3Client") RestS3Service s3Client,
@JsonProperty("parser") StringInputRowParser parser,
@JsonProperty("uris") List<URI> uris
)
{
this.s3Client = s3Client;
this.parser = Preconditions.checkNotNull(parser, "parser");
this.uris = ImmutableList.copyOf(uris);

for (final URI inputURI : uris) {
Preconditions.checkArgument(inputURI.getScheme().equals("s3"), "input uri scheme == s3 (%s)", inputURI);
}
}

@JsonProperty
public StringInputRowParser getParser()
{
return parser;
}

@JsonProperty
public List<URI> getUris()
{
Expand Down Expand Up @@ -151,7 +142,7 @@ public void remove()
throw new UnsupportedOperationException();
}
},
(StringInputRowParser) firehoseParser
firehoseParser
);
}
}

0 comments on commit dd9b646

Please sign in to comment.