-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental metronome state feedback #21
base: master
Are you sure you want to change the base?
Experimental metronome state feedback #21
Conversation
brummbrum
commented
May 28, 2019
- Metronome Button light works properly with this
- Polling frequency for metronome state approx 1/s
More actions and fixes
Direct track selection in Mixer view w top row buttons
Mixer Mode Track Navigation
Direct API calls for track selection rather than Reaper actions to overcome 99 track limit
Track selection working Non existing tracks in last bank are now properly marked as not available
Bank selection
VU meter data format ok, but: - Need a better hook (update frequency) - VU meter updates not working properly. CMD_SEL_TRACK_PARAMS_CHANGED not fully understood yet
VU: - functionality is there! - some minor tweaks like scaling still open - code cleanup required
native conversion taken from Reaper SDK
- Calibration also valid for other keyboards than S Mk2?
-Meters working -Precise, non linear calibration for KK Mk2 Display Meters
Update niMidi.cpp
- Stub to isolate this pull request from fork master
minus96dB and code simplification
- incl editiorial changes (comments, function names, variable names) for a clearer understanding
Volume text in mixer view
Changes to tracklist update the Mixer View
includes Repeat (=Loop) button
Transport Button Lights working
- also simplified code for Volume text by using Reaper's built in conversion
Pan Marker and Callback working
- also changed some constant names to reflect their actual meaning
Volume & Pan change of selected track via 4D encoder
- still missing: Mute Solo selected track incl. light indicators
- Commands and callbacks working - Rec Arm callback working - Small fix for meters (muted & soloed is now considered)
Mute solo rec arm callbacks
- Track name changes get reflected via callback - Master track indicated in Mixer View (no mute or solo on Master) - Bank slect button light
Track names, master track, bank button lights
- implemented in plugin by supressing peaks because KK firmware does not use this command at all (yet?) - maybe some newer firmware version of KK will do so
Track(s) muted by solo implemented
Thoughts on hooking the toggle metronome action, rather than polling? That will definitely catch changes from the PC keyboard, mouse and KK. It won't catch changes made in the Metronome Settings dialog, but I think we can probably live with that. See the hookpostcommand option to REAPER's plugin_register function. |
Scrap that. We can check for the CSURF_EXT_SETMETRONOME call passed to the Extended() method of the surface. parm1 will be 0 if disabled, !0 if enabled. This stuff is quite badly documented. :( |
great find, thank you! will try this. |
The CSURF_EXT_SETMETRONOME call passed to the Extended() method works fine. The only drawback in comparison to continuous polling is that we do not capture a difference in metronome state when switching between project tabs. For that reason I included the active poll into the SetSurfaceSelected callback which gets also called when the project tab changes. On all other occasions we are being called event driven by the Extended() method whenever the metronome status changes. Pull request coming up. |