Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
jdegand authored Aug 10, 2021
1 parent 33d0e81 commit a03c7c3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -25,9 +25,6 @@

## Overview

![screenshot](screenshot.png)


- I don't like that the real website has a line break on the address. There is also a picture that blends in with the background and that could have used a box-shadow or a picture replacement. The vertical panels are a striking design choice. Having menu items pop up on hover doesn't really help convert sales or convey info to the customer. It's different just to be different. It was unclear that they could be clicked on because of the hover as well. 'Interested in becoming a vendor?' is a weak, generic call to action. Getting people to click that button is very important and the button should be black at all times to stand out. Real site seems to use javascript to create panel content on load / click. Real site uses GSAP. GSAP doesn't really seem necessary.


@@ -55,4 +52,4 @@ The [challenge](https://www.frontendpractice.com/project/canal-street-market) wa
- [Free Frontend](https://freefrontend.com/css-border-animations/) - CSS border animations
- [Stack Overflow](https://stackoverflow.com/questions/28365839/dashed-border-animation-in-css3-animation) - Dashed border animation *
- [What Font is](https://www.whatfontis.com/VL_Ogg-Roman.similar) - Replacement for Ogg Roman font
- [ffonts](https://www.ffonts.net/LibreCaslonDisplay-Regular.font.download) - Font downloads
- [ffonts](https://www.ffonts.net/LibreCaslonDisplay-Regular.font.download) - Font downloads

0 comments on commit a03c7c3

Please sign in to comment.