refactor(pagination): data abstraction via hooks #2988
Conversation
Walkthrough该提交引入了一个新的分页钩子（usePagination），用于集中管理分页相关的逻辑。新的钩子在 Changes
Sequence Diagram(s)sequenceDiagram
participant User as 用户
participant PC as 分页组件
participant UP as usePagination 钩子
User->>PC: 点击分页按钮或前/后翻页按钮
PC->>UP: 调用 usePagination(total, current, ...options)
UP-->>PC: 返回 pages 与 pageCount
PC->>PC: 更新状态(current)并重新渲染分页组件
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS Optional dependencies cannot be installed without production dependencies ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
action:review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #2988 +/- ##
=============================================
+ Coverage 86.10% 86.15% +0.04%
=============================================
Files 277 278 +1
Lines 18408 18470 +62
Branches 2807 2814 +7
=============================================
+ Hits 15851 15912 +61
- Misses 2552 2553 +1
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/packages/pagination/pagination.tsx (1)
142-142: 静态分析提示测试覆盖率不足。
第 142 行涉及渲染处理，可能在测试中未覆盖mode="lite"或者特殊场景。可添加对这部分渲染和点击交互的测试用例，以提高整体测试覆盖率。需要帮助编写测试用例吗？我可以提供一个基础测试方案来确保此代码路径得到充分验证。
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 142-142: src/packages/pagination/pagination.tsx#L142
Added line #L142 was not covered by testssrc/packages/pagination/pagination.taro.tsx (1)
95-99: 前一页按钮的可用状态样式逻辑清晰，但可考虑辅助文本提示。
建议在禁用时加上相应的aria-disabled等属性以增强可访问性。<View className={classNames({ ... })} + aria-disabled={current === 1} onClick={() => prevPage()} >src/hooks/use-pagination.ts (2)
30-32:human2Machine函数命名直观，但使用自减运算符可能引发误解。
减少一行后再返回，容易让读者对返回值及副作用判断不清，可将number - 1直接写在 return 中以提升可读性。-function human2Machine(number: number) { - return --number +function human2Machine(number: number) { + return number - 1 }
52-53: 静态分析提示分支场景的测试覆盖率不足。
在calculateButtons内部，当尾部触达极限或首部边界时，会触发不同的start/end调整逻辑；静态分析的警告显示这部分可能缺乏测试用例。可通过添加极端场景（大分页数、小分页数等）进行验证，确保所有分支能正确执行。是否需要我为这些分支逻辑提供示例测试代码，以便及时补充测试覆盖率？
Also applies to: 55-56
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 52-53: src/hooks/use-pagination.ts#L52-L53
Added lines #L52 - L53 were not covered by tests
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
packages/nutui-taro-demo/config/index.js(1 hunks)packages/nutui-taro-demo/tsconfig.json(1 hunks)src/hooks/use-pagination.ts(1 hunks)src/packages/pagination/pagination.taro.tsx(4 hunks)src/packages/pagination/pagination.tsx(4 hunks)tsconfig.h5.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- tsconfig.h5.json
🧰 Additional context used
🪛 GitHub Check: codecov/patch
src/packages/pagination/pagination.tsx
[warning] 142-142: src/packages/pagination/pagination.tsx#L142
Added line #L142 was not covered by tests
src/hooks/use-pagination.ts
[warning] 52-53: src/hooks/use-pagination.ts#L52-L53
Added lines #L52 - L53 were not covered by tests
[warning] 55-56: src/hooks/use-pagination.ts#L55-L56
Added lines #L55 - L56 were not covered by tests
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
🔇 Additional comments (9)
src/packages/pagination/pagination.tsx (3)
59-64: 在usePropsValue中使用current状态没有问题，命名清晰且与组件语义相符。
此处逻辑简单明了，能够有效同步外部value与内部状态，不存在明显问题。
74-78: 点击事件的边界检查非常必要，避免了无效操作。
对于超出范围或已经选中的页码进行了短路处理，可读性和安全性都较好。
125-125: 在简单模式下显示当前页码与总页数，能保持简洁，但仍需注意用例覆盖。
建议在测试中包含mode="simple"的场景，确保current与pageCount的计算与渲染在极端值时也能正确工作。src/packages/pagination/pagination.taro.tsx (2)
76-80: 点击事件边界校验合理，可避免无效或重复操作。
与普通版组件的要点保持一致，防止用户在边界外翻页导致状态异常。
142-143: 与行 142-143 相关的颜色设置需完善测试覆盖率。
同样地，如果在某些模式下next按钮在边界不可用，需测试并验证addColorForHarmony对配色的处理是否符合预期。src/hooks/use-pagination.ts (1)
76-97: “省略符号”逻辑设计良好，可读性高。
在项目需求中常见此模式，可灵活隐藏中间页码。整体实现足以应对大部分分页场景，无需额外改动。packages/nutui-taro-demo/config/index.js (1)
123-123: 新增 hooks 别名配置正确！新增的
@/hooks别名配置遵循了项目现有的别名命名规范，路径解析也正确指向了 hooks 目录。这个改动很好地支持了通过 hooks 实现数据抽象的目标。packages/nutui-taro-demo/tsconfig.json (2)
34-36: TypeScript 路径映射配置完善！新增的
@/hooks路径映射与现有配置保持一致，正确使用了通配符模式。这个配置确保了 TypeScript 能够正确解析 hooks 模块的导入。
123-123:✅ Verification successful
验证 hooks 配置的一致性
建议验证 hooks 目录结构是否已经建立，确保配置能够正常工作。
Also applies to: 34-36
🏁 Script executed:
#!/bin/bash # 验证 hooks 目录是否存在且包含文件 test -d src/hooks && find src/hooks -type f -name "*.ts" -o -name "*.tsx"Length of output: 102
验证 hooks 配置一致性
经过验证，项目中
src/hooks/目录已存在，并且包含诸如src/hooks/use-pagination.ts文件，证明 hooks 配置在各文件中是一致且正确的。同时，其他提到的配置（如 34-36 行）也保持了相应的一致性。请确保所有 hooks 文件维持该配置要求。
github-actions
bot
added
action:review
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
src/packages/pagination/pagination.tsx (2)
74-86: 建议优化事件处理函数的结构！通过使用提前返回（early return）模式可以使代码更清晰：
const prevPage = () => { - const prev = current - 1 - prev >= 1 && setCurrent(prev) + if (current <= 1) return + setCurrent(current - 1) } const nextPage = () => { - const next = current + 1 - next <= pageCount && setCurrent(next) + if (current >= pageCount) return + setCurrent(current + 1) }
142-142: 需要补充测试用例！
lite模式的渲染逻辑缺少测试覆盖。建议添加以下场景的测试：
- 验证当前页码显示
- 验证分隔符显示
- 验证总页数显示
需要我帮您生成测试用例吗？
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 142-142: src/packages/pagination/pagination.tsx#L142
Added line #L142 was not covered by testssrc/packages/pagination/pagination.taro.tsx (2)
130-130: 可以简化字符串模板的使用！-{`${current}/${pageCount}`} +{current}/{pageCount}当前的模板字符串用法过于复杂，可以简化为直接的 JSX 表达式。
1-160: 建议提取共享逻辑！Web 版本和 Taro 版本的分页组件存在大量重复代码。建议：
- 创建一个共享的基础组件类，包含通用的分页逻辑
- Web 和 Taro 版本继承这个基础类，只处理平台特定的渲染逻辑
- 使用组合模式将通用的计算逻辑与平台特定的 UI 渲染分离
这样可以：
- 减少代码重复
- 简化维护工作
- 确保跨平台行为一致性
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/packages/pagination/pagination.taro.tsx(4 hunks)src/packages/pagination/pagination.tsx(4 hunks)
🧰 Additional context used
🪛 GitHub Check: codecov/patch
src/packages/pagination/pagination.tsx
[warning] 142-142: src/packages/pagination/pagination.tsx#L142
Added line #L142 was not covered by tests
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
🔇 Additional comments (1)
src/packages/pagination/pagination.tsx (1)
1-74: 代码重构改进了关注点分离！通过引入
usePagination钩子将分页逻辑抽象到独立的模块中，提高了代码的可维护性和可重用性。同时使用ButtonItem类型增强了类型安全性。
oasis-cloud
changed the title
| </div> | ||
| </div> | ||
| )} | ||
| <div | ||
| className={classNames( | ||
| `${classPrefix}-next`, | ||
| currentPage >= pageCount ? `${classPrefix}-next-disabled` : '' | ||
| current >= pageCount ? `${classPrefix}-next-disabled` : '' |
src/hooks/use-pagination.ts
Outdated
| ellipse: boolean | ||
| } | ||
|
|
||
| export type ButtonItem = { number: number; text: string; selected?: boolean } |
There was a problem hiding this comment.
听上去像个节点。。可以直接叫 PaginationOption
src/hooks/use-pagination.ts
Outdated
| // 指示器 | ||
| buttons: Array<ButtonItem>, | ||
| // 指示器的总数量 | ||
| buttonsCount: number, |
# Conflicts: # src/packages/pagination/pagination.taro.tsx # src/packages/pagination/pagination.tsx
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
src/hooks/use-pagination.ts (5)
1-12: 建议导出 PaginationOptions 接口PaginationOptions 接口定义了分页参数，但它没有被导出。由于 usePagination 钩子接受这个接口作为参数，建议将其导出，使外部调用者能够更清晰地了解所需参数的类型。
-interface PaginationOptions { +export interface PaginationOptions { // 当前页码, 从 1 开始 current: number // 数据总条数 total: number // 每页显示的条目数 itemsPerPage: number // 指示器条目数量 displayCount: number // 省略符号 ellipse: boolean }
20-25: 建议使用小写命名PaginationResult 类型中的字段名称
PaginationNodes和PaginationNodesCount使用了大写开头，不符合 TypeScript/JavaScript 的常规变量命名规范。建议改为小写开头，以保持命名一致性。type PaginationResult = [ // 指示器 - PaginationNodes: Array<PaginationNode>, + paginationNodes: Array<PaginationNode>, // 指示器的总数量 - PaginationNodesCount: number, + paginationNodesCount: number, ]
34-36: 建议使用更具描述性的函数名
human2Machine函数名称不够直观，难以理解其用途。建议使用更具描述性的名称，如oneBasedToZeroBased或humanIndexToMachineIndex。-function human2Machine(number: number) { +function oneBasedToZeroBased(number: number) { return --number }
80-101: 避免直接修改数组
addEllipses函数直接修改了传入的nodes数组，这在 React 环境中可能导致不可预期的行为。建议返回一个新数组，避免副作用。function addEllipses( nodes: Array<PaginationNode>, { displayCount, nodesCount, ellipse, }: { displayCount: number; nodesCount: number; ellipse: boolean } ) { if (nodesCount <= displayCount || !ellipse) return nodes const start = nodes[0] const end = nodes[nodes.length - 1] const leftEllipse = start.number > 1 const rightEllipse = end.number < nodesCount + const result = [...nodes] if (leftEllipse) { - nodes.unshift({ number: start.number - 1, text: '...' }) + result.unshift({ number: start.number - 1, text: '...' }) } if (rightEllipse) { - nodes.push({ number: end.number + 1, text: '...' }) + result.push({ number: end.number + 1, text: '...' }) } - return nodes + return result }
103-112: 添加输入验证
usePagination钩子没有验证输入参数的有效性，例如itemsPerPage应该大于 0。建议添加适当的验证逻辑以提高代码的健壮性。export const usePagination = (options: PaginationOptions): PaginationResult => { const mergedOptions = { ...defaultPaginationOptions, ...options, } const { total, itemsPerPage } = mergedOptions + + if (itemsPerPage <= 0) { + throw new Error('itemsPerPage must be greater than 0') + } + const nodesCount = Math.ceil((total || 0) / itemsPerPage) || 1 return [calculateNodes(mergedOptions, nodesCount), nodesCount] }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/hooks/use-pagination.ts(1 hunks)
🧰 Additional context used
🪛 GitHub Check: codecov/patch
src/hooks/use-pagination.ts
[warning] 56-57: src/hooks/use-pagination.ts#L56-L57
Added lines #L56 - L57 were not covered by tests
[warning] 59-60: src/hooks/use-pagination.ts#L59-L60
Added lines #L59 - L60 were not covered by tests
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
| const defaultPaginationOptions: Partial<PaginationOptions> = { | ||
| current: 0, | ||
| itemsPerPage: 10, | ||
| displayCount: 5, | ||
| ellipse: false, | ||
| } |
There was a problem hiding this comment.
修正默认值与接口定义的不一致
根据接口注释，current 应该从 1 开始计数，但默认值却设为了 0。这与接口定义不符，可能导致计算错误。
const defaultPaginationOptions: Partial<PaginationOptions> = {
- current: 0,
+ current: 1,
itemsPerPage: 10,
displayCount: 5,
ellipse: false,
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const defaultPaginationOptions: Partial<PaginationOptions> = { | |
| current: 0, | |
| itemsPerPage: 10, | |
| displayCount: 5, | |
| ellipse: false, | |
| } | |
| const defaultPaginationOptions: Partial<PaginationOptions> = { | |
| current: 1, | |
| itemsPerPage: 10, | |
| displayCount: 5, | |
| ellipse: false, | |
| } |
| function calculateNodes(options: PaginationOptions, nodesCount: number) { | ||
| // 分页器内部的索引从 0 开始，用户使用的索引从 1 开始 | ||
| const halfIndex = Math.floor(options.displayCount / 2) | ||
| const buttonsCountIndex = human2Machine(nodesCount) | ||
| const displayCountIndex = human2Machine(options.displayCount) | ||
| const currentIndex = human2Machine(options.current) | ||
| let start | ||
| let end | ||
| if (buttonsCountIndex <= displayCountIndex) { | ||
| start = 0 | ||
| end = buttonsCountIndex | ||
| } else { | ||
| start = Math.max(0, currentIndex - halfIndex) | ||
| end = Math.min(buttonsCountIndex, currentIndex + halfIndex) | ||
| if (end - start < displayCountIndex) { | ||
| if (start === 0) { | ||
| end = Math.min(start + displayCountIndex, buttonsCountIndex) | ||
| } else if (end === buttonsCountIndex) { | ||
| start = Math.max(end - displayCountIndex, 1) | ||
| } | ||
| } else if (end - start > displayCountIndex) { | ||
| end = start + displayCountIndex | ||
| } | ||
| } | ||
|
|
||
| const buttons = [] | ||
| for (let i = start; i <= end; i++) { | ||
| const humanPageNumber = i + 1 | ||
| buttons.push({ | ||
| number: humanPageNumber, | ||
| text: humanPageNumber.toString(), | ||
| selected: options.current === humanPageNumber, | ||
| }) | ||
| } | ||
|
|
||
| return addEllipses(buttons, { | ||
| nodesCount, | ||
| ellipse: options.ellipse, | ||
| displayCount: options.displayCount, | ||
| }) | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
优化 calculateNodes 函数
calculateNodes 函数有几个需要注意的地方：
- 函数内部调用
human2Machine的地方应更新为新的函数名 - 第 56 行的
Math.max(end - displayCountIndex, 1)中，最小值应为 0 而非 1，因为索引是从 0 开始的 - 缺少对
options.displayCount为 0 或负数的验证，可能导致计算错误
同时，根据静态分析，第 56-57 行和 59-60 行代码未被测试覆盖，建议增加相应测试用例。
function calculateNodes(options: PaginationOptions, nodesCount: number) {
// 分页器内部的索引从 0 开始，用户使用的索引从 1 开始
const halfIndex = Math.floor(options.displayCount / 2)
- const buttonsCountIndex = human2Machine(nodesCount)
- const displayCountIndex = human2Machine(options.displayCount)
- const currentIndex = human2Machine(options.current)
+ const buttonsCountIndex = oneBasedToZeroBased(nodesCount)
+ const displayCountIndex = oneBasedToZeroBased(options.displayCount)
+ const currentIndex = oneBasedToZeroBased(options.current)
+ if (options.displayCount <= 0) {
+ throw new Error('displayCount must be greater than 0')
+ }
let start
let end
if (buttonsCountIndex <= displayCountIndex) {
start = 0
end = buttonsCountIndex
} else {
start = Math.max(0, currentIndex - halfIndex)
end = Math.min(buttonsCountIndex, currentIndex + halfIndex)
if (end - start < displayCountIndex) {
if (start === 0) {
end = Math.min(start + displayCountIndex, buttonsCountIndex)
} else if (end === buttonsCountIndex) {
- start = Math.max(end - displayCountIndex, 1)
+ start = Math.max(end - displayCountIndex, 0)
}
} else if (end - start > displayCountIndex) {
end = start + displayCountIndex
}
}
const buttons = []
for (let i = start; i <= end; i++) {
const humanPageNumber = i + 1
buttons.push({
number: humanPageNumber,
text: humanPageNumber.toString(),
selected: options.current === humanPageNumber,
})
}
return addEllipses(buttons, {
nodesCount,
ellipse: options.ellipse,
displayCount: options.displayCount,
})
}请运行以下脚本验证未覆盖的代码路径：
🏁 Script executed:
#!/bin/bash
echo "检查未覆盖的代码路径..."
echo "查找测试文件:"
fd -t f --exec grep -l "usePagination" {} \; | grep test
echo "查找测试覆盖率报告:"
fd -t f -e json coverageLength of output: 457
修正 calculateNodes 函数调用和边界验证问题
- 请将函数内部调用
human2Machine替换为oneBasedToZeroBased以保持一致； - 对于第 56 行的调整，修改
Math.max(end - displayCountIndex, 1)为Math.max(end - displayCountIndex, 0)，确保索引从 0 开始； - 增加对
options.displayCount参数的有效性验证（仅允许正数），防止出现计算错误； - 注意：当前代码中第 56-57 行以及第 59-60 行的逻辑没有对应测试覆盖，请补充相应的单元测试确保这部分逻辑的正确性。
Diff 供参考：
function calculateNodes(options: PaginationOptions, nodesCount: number) {
// 分页器内部的索引从 0 开始，用户使用的索引从 1 开始
- const buttonsCountIndex = human2Machine(nodesCount)
- const displayCountIndex = human2Machine(options.displayCount)
- const currentIndex = human2Machine(options.current)
+ const buttonsCountIndex = oneBasedToZeroBased(nodesCount)
+ const displayCountIndex = oneBasedToZeroBased(options.displayCount)
+ const currentIndex = oneBasedToZeroBased(options.current)
+ if (options.displayCount <= 0) {
+ throw new Error('displayCount must be greater than 0')
+ }
let start
let end
if (buttonsCountIndex <= displayCountIndex) {
start = 0
end = buttonsCountIndex
} else {
start = Math.max(0, currentIndex - halfIndex)
end = Math.min(buttonsCountIndex, currentIndex + halfIndex)
if (end - start < displayCountIndex) {
if (start === 0) {
end = Math.min(start + displayCountIndex, buttonsCountIndex)
} else if (end === buttonsCountIndex) {
- start = Math.max(end - displayCountIndex, 1)
+ start = Math.max(end - displayCountIndex, 0)
}
} else if (end - start > displayCountIndex) {
end = start + displayCountIndex
}
}
// ... 省略后续代码
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| function calculateNodes(options: PaginationOptions, nodesCount: number) { | |
| // 分页器内部的索引从 0 开始，用户使用的索引从 1 开始 | |
| const halfIndex = Math.floor(options.displayCount / 2) | |
| const buttonsCountIndex = human2Machine(nodesCount) | |
| const displayCountIndex = human2Machine(options.displayCount) | |
| const currentIndex = human2Machine(options.current) | |
| let start | |
| let end | |
| if (buttonsCountIndex <= displayCountIndex) { | |
| start = 0 | |
| end = buttonsCountIndex | |
| } else { | |
| start = Math.max(0, currentIndex - halfIndex) | |
| end = Math.min(buttonsCountIndex, currentIndex + halfIndex) | |
| if (end - start < displayCountIndex) { | |
| if (start === 0) { | |
| end = Math.min(start + displayCountIndex, buttonsCountIndex) | |
| } else if (end === buttonsCountIndex) { | |
| start = Math.max(end - displayCountIndex, 1) | |
| } | |
| } else if (end - start > displayCountIndex) { | |
| end = start + displayCountIndex | |
| } | |
| } | |
| const buttons = [] | |
| for (let i = start; i <= end; i++) { | |
| const humanPageNumber = i + 1 | |
| buttons.push({ | |
| number: humanPageNumber, | |
| text: humanPageNumber.toString(), | |
| selected: options.current === humanPageNumber, | |
| }) | |
| } | |
| return addEllipses(buttons, { | |
| nodesCount, | |
| ellipse: options.ellipse, | |
| displayCount: options.displayCount, | |
| }) | |
| } | |
| function calculateNodes(options: PaginationOptions, nodesCount: number) { | |
| // 分页器内部的索引从 0 开始，用户使用的索引从 1 开始 | |
| const halfIndex = Math.floor(options.displayCount / 2) | |
| const buttonsCountIndex = oneBasedToZeroBased(nodesCount) | |
| const displayCountIndex = oneBasedToZeroBased(options.displayCount) | |
| const currentIndex = oneBasedToZeroBased(options.current) | |
| if (options.displayCount <= 0) { | |
| throw new Error('displayCount must be greater than 0') | |
| } | |
| let start | |
| let end | |
| if (buttonsCountIndex <= displayCountIndex) { | |
| start = 0 | |
| end = buttonsCountIndex | |
| } else { | |
| start = Math.max(0, currentIndex - halfIndex) | |
| end = Math.min(buttonsCountIndex, currentIndex + halfIndex) | |
| if (end - start < displayCountIndex) { | |
| if (start === 0) { | |
| end = Math.min(start + displayCountIndex, buttonsCountIndex) | |
| } else if (end === buttonsCountIndex) { | |
| start = Math.max(end - displayCountIndex, 0) | |
| } | |
| } else if (end - start > displayCountIndex) { | |
| end = start + displayCountIndex | |
| } | |
| } | |
| const buttons = [] | |
| for (let i = start; i <= end; i++) { | |
| const humanPageNumber = i + 1 | |
| buttons.push({ | |
| number: humanPageNumber, | |
| text: humanPageNumber.toString(), | |
| selected: options.current === humanPageNumber, | |
| }) | |
| } | |
| return addEllipses(buttons, { | |
| nodesCount, | |
| ellipse: options.ellipse, | |
| displayCount: options.displayCount, | |
| }) | |
| } |
🧰 Tools
🪛 GitHub Check: codecov/patch
[warning] 56-57: src/hooks/use-pagination.ts#L56-L57
Added lines #L56 - L57 were not covered by tests
[warning] 59-60: src/hooks/use-pagination.ts#L59-L60
Added lines #L59 - L60 were not covered by tests
Summary by CodeRabbit