-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs): 修复tabs数量过多时的滚动操作bug #3014
Conversation
Walkthrough此次变更简化了滚动逻辑。在 Changes
Sequence Diagram(s)sequenceDiagram
participant U as 用户触发事件
participant SI as scrollIntoView
participant SD as scrollDirection
participant SC as 滚动组件
U->>SI: 请求滚动至位置
SI->>SD: 调用 scrollDirection(to, direction)
alt direction == horizontal
SD->>SC: 调用 setScrollLeft(to)
else direction == vertical
SD->>SC: 调用 setScrollTop(to)
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3014 +/- ##
=======================================
Coverage 85.56% 85.56%
=======================================
Files 267 267
Lines 18003 18003
Branches 2726 2726
=======================================
Hits 15405 15405
Misses 2595 2595
Partials 3 3 ☔ View full report in Codecov by Sentry. |
#2554 此PR的错乱问题从逻辑上看起来与父级tab的滚动距离没有关系 |
Tabs 数量多,滚动操作时有bug #2653
[FR]: Tabs增加控制自定义内部ScrollIntoView的方法 #2923
Tabs 选项卡 数量多横向切换滚动位置bug #2930
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit