Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config v15 调整 #3046

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

xiaoyatong
Copy link
Collaborator

@xiaoyatong xiaoyatong commented Mar 5, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • Chores
    • 更新了多个组件的配置设置,将原有的布尔标识调整为不同的整数值,从而实现更精细的控制和一致性优化。这项更新旨在提升各组件在不同场景下的响应表现,并进一步增强系统的整体稳定性。

Copy link

coderabbitai bot commented Mar 5, 2025

Walkthrough

本次 PR 修改了配置文件 src/config.json 中各组件的 v15 属性,将原本的布尔值 true 替换为多个不同的整数值(例如 1、99、100、-1、2)。该修改影响了 Button、Cell、ConfigProvider、Icon、Image、Overlay 等多个组件,且仅调整了属性值,未新增或删除其他属性。

Changes

文件 变更摘要
src/config.json 更新多个组件中的 v15 属性值,将 true 替换为整数(1、99、100、-1、2)。

Possibly related PRs

Suggested reviewers

  • oasis-cloud

Poem

我是一只快乐的小兔子,
在代码森林中蹦跳不停,
数字闪烁映出新奇意,
布尔转整数绘梦影,
变化虽小心欢喜,
同道齐庆未来锦!
🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd87f6 and 26fabe1.

📒 Files selected for processing (1)
  • src/config.json (89 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build
  • GitHub Check: test
🔇 Additional comments (8)
src/config.json (8)

82-82: 基础组件的 v15 配置更新:
在 Button、Cell、CellGroup、ConfigProvider、Icon、Image 与 Overlay 组件中,将 v15 属性原先的布尔值修改为整数,具体数值分别为 1、100、100、99、1、99 和 100。请确认这些数值是否与新版组件设计及版本分支逻辑相符。

Also applies to: 95-95, 108-108, 123-123, 137-137, 151-151, 163-163


182-182: 布局组件的 v15 配置更新:
在 Divider、Grid、Layout、SafeArea、Space 和 Sticky 组件中,v15 属性的数值分别更新为 100、1、99、99、100 与 99。请检查各配置数值与设计文档中的定义是否一致,并确保不会影响组件布局逻辑。

Also applies to: 195-195, 221-221, 258-258, 271-271, 284-284


303-303: 导航组件的 v15 配置更新:
对于 BackTop、Elevator、FixedNav、HoverButton、NavBar 与 SideBar 组件,v15 属性分别更新为 1、-1、100、1、1 和 1。其中,Elevator 使用的 -1 数值可能表示特殊状态或禁用选项,请再次确认其语义是否符合预期。

Also applies to: 316-316, 330-330, 342-342, 369-369, 382-382


500-500: 数据录入组件(第一部分)的 v15 配置更新:
在 Address、Calendar、CalendarCard、Cascader、Checkbox、DatePicker、Form、Input 与 InputNumber 组件中,v15 属性分别更改为 2、100、100、100、1、-1、2、1 及 1。请特别核查 DatePicker 中的 -1 数值是否与预期的特殊情形匹配。

Also applies to: 514-514, 539-539, 552-552, 564-564, 589-589, 602-602, 628-628, 641-641


660-660: 数据录入组件(第二部分)的 v15 配置更新:
对于 Menu、NumberKeyboard、Picker、PickerView、Radio、RadioGroup、Range 与 Rate 组件,v15 属性分别更新为 2、-1、-1、-1、1、1、-1 与 1。请重点确认所有 -1 数值的用法,确保在各组件中均具有一致且合理的语义。

Also applies to: 686-686, 699-699, 712-712, 725-725, 738-738, 751-751, 764-764


862-862: 操作反馈组件的 v15 配置更新:
在 ActionSheet、Badge、Dialog、Drag、Empty、InfiniteLoading、Loading、NoticeBar、Notify、Popover、Popup、PullToRefresh、ResultPage、Skeleton、Swipe 与 Toast 组件中,更新后的 v15 数值分别为 2、1、1、99、1、1、1、2、2、1、1、1、1、2、2 与 1。请核实这些配置值能否确保反馈交互效果正常并与现有 UI 行为匹配。

Also applies to: 875-875, 888-888, 901-901, 914-914, 927-927, 941-941, 953-953, 966-966, 979-979, 991-991, 1006-1006, 1019-1019, 1032-1032, 1046-1046, 1058-1058


1077-1077: 展示组件的 v15 配置更新:
在展示组件中,各组件的 v15 属性更新情况如下:
• Animate:99
• AnimatingNumbers:99
• Avatar:100
• CircleProgress:-1
• Collapse:-1
• CountDown:1
• Ellipsis:99
• ImagePreview:2
• Indicator:1
• Lottie:1
• Pagination:1
• Price:1
• Progress:2
• Segmented:1
• Steps:2
• Swiper:2
• Table:-1
• Tag:100
• Tour:-1
• Video:-1
• VirtualList:100
请特别确认所有 -1 数值在各组件中是否具有统一且正确的语义,其它数值也需符合新版设计要求。

Also applies to: 1090-1090, 1115-1115, 1141-1141, 1153-1153, 1178-1178, 1191-1191, 1204-1204, 1217-1217, 1230-1230, 1243-1243, 1256-1256, 1269-1269, 1282-1282, 1306-1306, 1319-1319, 1345-1345, 1357-1357, 1370-1370, 1383-1383, 1396-1396


1415-1415: 特色组件的 v15 配置更新:
在 AvatarCropper、Barrage、Card、TimeSelect、TrendArrow 与 WaterMark 组件中,v15 属性分别更新为 -1、-1、-1、-1、100 与 99。请确认 -1 数值是否用作特殊配置标识,以及 TrendArrow 与 WaterMark 的新数值是否与预期的视觉或功能策略保持一致。

Also applies to: 1428-1428, 1441-1441, 1467-1467, 1479-1479, 1492-1492


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added action:review This PR needs more reviews (less than 2 approvals) 3.x Target branch 3.x labels Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.05%. Comparing base (4fd87f6) to head (26fabe1).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3046   +/-   ##
==========================================
  Coverage      86.05%   86.05%           
==========================================
  Files            281      281           
  Lines          18255    18255           
  Branches        2749     2749           
==========================================
  Hits           15709    15709           
  Misses          2541     2541           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alex-huxiyang Alex-huxiyang merged commit ea7bb0b into jdf2e:feat_v3.x Mar 5, 2025
8 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 7, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants