-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 调整dd展示 #3052
fix: 调整dd展示 #3052
Conversation
Walkthrough本次更新对文档说明和配置文件做了调整。文档 ( Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (33)
💤 Files with no reviewable changes (33)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3052 +/- ##
=============================================
- Coverage 86.11% 86.06% -0.05%
=============================================
Files 283 275 -8
Lines 18399 18234 -165
Branches 2768 2751 -17
=============================================
- Hits 15845 15694 -151
+ Misses 2549 2535 -14
Partials 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
migrate-from-v2.md (2)
136-138
: 【SideNavBar弃用说明】文档说明清晰
文档中对于 SideNavBar 的更新提示已经明确指出该组件因不符合移动端规范而被废弃,并建议使用 SideBar 进行替换。建议检查强调符号周围的空格,确保符合 markdownlint 规范。🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
138-138: Spaces inside emphasis markers
null(MD037, no-space-in-emphasis)
138-138: Spaces inside emphasis markers
null(MD037, no-space-in-emphasis)
224-226
: 【Audio组件说明更新】传达 Taro 多端支持状态
对于 Audio 组件的说明已更新,明确指出该组件在 Taro 多端上没有计划支持,建议用户使用相关 API 替代。请注意检查文档中的格式细节,避免因空格问题触发 markdownlint 警告。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
migrate-from-v2.md
(2 hunks)src/config.json
(12 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
migrate-from-v2.md
138-138: Spaces inside emphasis markers
null
(MD037, no-space-in-emphasis)
138-138: Spaces inside emphasis markers
null
(MD037, no-space-in-emphasis)
227-227: Spaces inside emphasis markers
null
(MD037, no-space-in-emphasis)
227-227: Spaces inside emphasis markers
null
(MD037, no-space-in-emphasis)
🔇 Additional comments (11)
src/config.json (11)
283-286
: 【Sticky组件配置】确认属性更新
Sticky 组件的"v15"
参数已更新为990
,同时"dd"
属性修改为false
。请确认这一改动与前端设计要求保持一致,确保该组件在新版中正确展示。
777-782
: 【签名组件配置】检查 Signature 组件更新
Signature 组件的"v15"
属性已调整为990
,同时"dd"
属性设置为false
。请确认这一改动与最新设计文档一致,不会影响组件的预期交互。
819-823
: 【上传组件配置】更新 Uploader 组件参数
Uploader 组件的"v15"
属性已修改为1000
,并将"dd"
置为false
。请检查此更新是否正确反映了后续版本对该组件状态的管理要求。
1053-1056
: 【动画组件配置】调整 Animate 组件参数
Animate 组件中的"v15"
属性现调整为990
,同时"dd"
改为false
。建议确认该配置与其它动画/动效组件标准保持一致。
1066-1069
: 【数字动画配置】检查 AnimatingNumbers 参数更新
AnimatingNumbers 组件的"v15"
参数更新为990
。请确认此更新不会对组件的动画效果产生不良影响,并与整体视觉风格相符合。
1079-1082
: 【音频播放器配置】明确 Taro 多端支持状态
Audio 组件的"v15"
设置为-1
,表明该组件在 Taro 多端上暂无支持,同时"dd"
为false
。请确保文档中对此说明得足够清晰,以便用户了解当前的使用限制。
1168-1171
: 【文本省略组件配置】更新 Ellipsis 参数
Ellipsis 组件的"v15"
已调整为990
,并将"dd"
修改为false
。请核对这一调整是否符合整体配置更新的意图和视觉规范。
1373-1376
: 【虚拟列表配置】验证 VirtualList 属性调整
VirtualList 组件的"v15"
属性现更新为1000
,同时"dd"
属性设置为false
。建议确认该改动与组件更新方案及预期展示效果相符。
1456-1459
: 【趋势箭头配置】检查 TrendArrow 参数更新
TrendArrow 组件的"v15"
参数已调整为1000
,而"dd"
依旧为true
。请核实这一改动是否能满足新设计对趋势展示的需求。
1469-1472
: 【水印组件配置】确认 WaterMark 属性更新
WaterMark 组件的"v15"
已修改为990
,并将"dd"
改为false
。请确认这一更新符合整体视觉风格及配置规范要求。
290-300
: 【废弃组件配置移除】核实已清除废弃配置
配置中已移除不再支持的 SideNavBar、SideNavBarItem 与 SubSideNavBar 组件的相关定义。请确认这些废弃组件已在所有文档和代码中被正确剔除,并提醒用户使用推荐的替代组件(如 SideBar)。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sidenavbar相关的得去干净,可以参考下未通过的ci
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
文档更新
内部调整