-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(countdown): 个位秒补0展示 #3072
fix(countdown): 个位秒补0展示 #3072
Conversation
Walkthrough此变更修改了 Changes
Sequence Diagram(s)sequenceDiagram
participant Countdown as InternalCountDown
participant TimeItem as renderTimeItem
participant Formatter as padZero
Countdown->>TimeItem: 调用 renderTimeItem(time, unit, formatUnit)
alt unit 存在且 != 'DD'
TimeItem->>Formatter: 调用 padZero(time)
Formatter-->>TimeItem: 返回格式化时间
else unit 未定义且 formatUnit == 'ss'
TimeItem->>Formatter: 调用 padZero(time)
Formatter-->>TimeItem: 返回格式化时间
else
TimeItem-->>Countdown: 返回原始 time
end
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS Optional dependencies cannot be installed without production dependencies 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3072 +/- ##
==========================================
Coverage 86.10% 86.10%
==========================================
Files 277 277
Lines 18406 18406
Branches 2807 2808 +1
==========================================
Hits 15849 15849
Misses 2552 2552
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit