Skip to content

Commit

Permalink
test(tabs): account for BC in AngularJS v1.5.1
Browse files Browse the repository at this point in the history
Due to a breaking change in v1.5.1 (introduced in
angular/angular.js@7617c08), a CSS
selector in `test/angularjs.org.spec.js` couldn't find the targeted element and failed.
This commit fixes the problem by manually wrapping the text nodes in `<span>` elements.

**NOTE:** The BC was reverted in v1.5.2, but will eventually be re-introduced in v1.6,
          so let's be prepared.

Closes angular#194
  • Loading branch information
gkalpak committed Mar 20, 2016
1 parent c2d33ef commit 40de825
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -950,9 +950,9 @@ <h2>JavaScript Projects</h2>
<script type="text/ng-template" id="tabs.html">
<tabs>
<pane title="Localization">
Date: {{ '2012-04-01' | date:'fullDate' }} <br>
Currency: {{ 123456 | currency }} <br>
Number: {{ 98765.4321 | number }} <br>
<span>Date: {{ '2012-04-01' | date:'fullDate' }}</span><br>
<span>Currency: {{ 123456 | currency }}</span><br>
<span>Number: {{ 98765.4321 | number }}</span><br>
</pane>
<pane title="Pluralization">
<div ng-controller="BeerCounter">
Expand Down

0 comments on commit 40de825

Please sign in to comment.