ISO 8601 #45
Open
ISO 8601 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Double check this before merging, just in case as my XSL-fu is not as great as my Python-fu. ;) |
|
BTW, while "+1030" is valid according to ISO 8601, most of the implementations online also conform to RFC 3339 and chances are that's what triggered the bug Leigh saw. |
|
This is probably related to: #43 |
|
Leigh has now mentioned that the adjustments made in the develop branch do fix this error, so I'm inclined to close this pull request. OTOH, I don't know whether or not it'll still help ... so I'm copping out and leaving the decision in @jelovirt's hands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this: 2017-11-28T20:43:12+1030 (that's current Adelaide timezone,
BTW, just to prove there are annoying, real world examples).