check bootsource URL is displaying on review step

jeremyary · Sep 10, 2021 · bd92fcb · bd92fcb
1 parent b0be4ee
commit bd92fcb
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 1 deletion.
diff --git a/.../packages/kubevirt-plugin/integration-tests-cypress/tests/disks/validate-rootdisk.spec.ts b/.../packages/kubevirt-plugin/integration-tests-cypress/tests/disks/validate-rootdisk.spec.ts
@@ -60,6 +60,7 @@ describe('Validate root disk', () => {
  before(() => {
  cy.Login();
  cy.visit('/');
+ cy.createProject(testName);
  });
 
  beforeEach(() => {
@@ -71,6 +72,10 @@ describe('Validate root disk', () => {
  cy.byButtonText('Cancel').click();
  });
 
+ after(() => {
+ cy.deleteTestProject(testName);
+ });
+
  it('ID(CNV-5469) Blank disk cannot be used as bootdisk', () => {
  addDisk(blankDisk);
  checkDiskBootable(blankDisk.name, false);

diff --git a/...s/kubevirt-plugin/integration-tests-cypress/tests/regression/validate-nad-for-pxe.spec.ts b/...s/kubevirt-plugin/integration-tests-cypress/tests/regression/validate-nad-for-pxe.spec.ts
@@ -17,9 +17,14 @@ describe('Validate NAD for PXE provision source', () => {
  before(() => {
  cy.Login();
  cy.visit('/');
+ cy.createProject(testName);
  cy.visitVMsList();
  });
 
+ after(() => {
+ cy.deleteTestProject(testName);
+ });
+
  it('ID(CNV-5045) Verify PXE provision source must have NAD available', () => {
  wizard.vm.open();
  wizard.vm.selectTemplate(vmData);

diff --git a/...ckages/kubevirt-plugin/integration-tests-cypress/tests/vm-template/template-rhel9.spec.ts b/...ckages/kubevirt-plugin/integration-tests-cypress/tests/vm-template/template-rhel9.spec.ts
@@ -1,3 +1,4 @@
+import { testName } from '../../support';
 import { TEMPLATE } from '../../utils/const/index';
 import { unStarIcon, supportLevel, supportLevelTag } from '../../views/selector';
 
@@ -7,10 +8,15 @@ describe('Test RHEL9 template', () => {
  before(() => {
  cy.Login();
  cy.visit('/');
+ cy.createProject(testName);
  cy.visitVMTemplatesList();
  cy.filterByName(template.dvName);
  });
 
+ after(() => {
+ cy.deleteTestProject(testName);
+ });
+
  // TODO: RHEL9 should be starred after it's official released.
  it('ID(CNV-7185) Verify RHEL9 template is not starred', () => {
  // mark it downstream only as upstream has no rhel9 template yet

diff --git a/frontend/packages/kubevirt-plugin/integration-tests-cypress/views/selector-wizard.ts b/frontend/packages/kubevirt-plugin/integration-tests-cypress/views/selector-wizard.ts
@@ -60,3 +60,6 @@ export const selectBootSource = 'select[id="storage-bootsource"]';
 export const rootdisk = '[data-id="rootdisk"]';
 export const kebabBtn = '[data-test-id="kebab-button"]';
 export const deleteBtn = '[data-test-action="Delete"]';
+
+// review step
+export const bootSource = '#wizard-review-provision_source_type';
diff --git a/frontend/packages/kubevirt-plugin/integration-tests-cypress/views/wizard.ts b/frontend/packages/kubevirt-plugin/integration-tests-cypress/views/wizard.ts
@@ -222,7 +222,13 @@ export const wizard = {
  cy.get(wizardView.nextBtn).click();
  },
  fillConfirmForm: (vmData: VirtualMachineData) => {
- const { startOnCreation } = vmData;
+ const { provisionSource, startOnCreation } = vmData;
+
+ // enhancement for https://issues.redhat.com/browse/CNV-5162
+ if (provisionSource === ProvisionSource.URL) {
+ cy.get(wizardView.bootSource).should('contain', provisionSource.getSource());
+ }
+
  cy.get('body').then(($body) => {
  if ($body.find(wizardView.startOnCreation).length) {
  if (!startOnCreation) {