Bug 2000391: review kubevirt skipped tests

jeremyary · Sep 2, 2021 · cbb7755 · cbb7755
1 parent 7824ba4
commit cbb7755
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 21 deletions.
diff --git a/...bevirt-plugin/integration-tests-cypress/tests/vm-template/custom-template-support.spec.ts b/...bevirt-plugin/integration-tests-cypress/tests/vm-template/custom-template-support.spec.ts
@@ -106,7 +106,7 @@ describe('test custom template creation support', () => {
  );
  });
 
- xit('ID(CNV-5729) create custom template from common template with a boot source', () => {
+ it('ID(CNV-5729) create custom template from common template with a boot source', () => {
  const NEW_TEMPLATE_NAME = `foo-with-source-${testName}`;
  const VM_NAME_WITH_BOOT_SOURCE = `foo-vm-with-source-${testName}`;
 
@@ -148,6 +148,16 @@ describe('test custom template creation support', () => {
  cy.byTestID('success-list').click();
 
  // verify VM started
+ virtualization.vms.testStatus(
+ VM_NAME_WITH_BOOT_SOURCE,
+ 'Provisioning',
+ VM_ACTION_TIMEOUT.VM_BOOTUP,
+ );
+ virtualization.vms.testStatus(
+ VM_NAME_WITH_BOOT_SOURCE,
+ 'Starting',
+ VM_ACTION_TIMEOUT.VM_BOOTUP,
+ );
  virtualization.vms.testStatus(VM_NAME_WITH_BOOT_SOURCE, 'Running', VM_ACTION_TIMEOUT.VM_BOOTUP);
  });
 });
diff --git a/...packages/kubevirt-plugin/integration-tests-cypress/tests/vm-template/source-image.spec.ts b/...packages/kubevirt-plugin/integration-tests-cypress/tests/vm-template/source-image.spec.ts
@@ -74,7 +74,7 @@ describe('test vm template source image', () => {
  virtualization.templates.testSource(template.name, ADD_SOURCE);
  });
 
- xit('ID(CNV-5649) upload image and delete', () => {
+ it('ID(CNV-5649) upload image and delete', () => {
  cy.exec(
  `test -f ${Cypress.env(
  'UPLOAD_IMG',
@@ -83,7 +83,7 @@ describe('test vm template source image', () => {
  );
  virtualization.templates.addSource(template.name);
  addSource.addBootSource(ProvisionSource.UPLOAD);
- virtualization.templates.testSource(template.name, 'Uploading');
+ virtualization.templates.testSource(template.name, 'Source uploading');
  virtualization.templates.testSource(template.name, TEST_PROVIDER);
  virtualization.templates.deleteSource(template.metadataName);
  virtualization.templates.testSource(template.name, ADD_SOURCE);

diff --git a/frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/vm/advanced-wizard.spec.ts b/frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/vm/advanced-wizard.spec.ts
@@ -1,14 +1,14 @@
 import { testName } from '../../support';
-import { VirtualMachineData } from '../../types/vm';
+import { Network, VirtualMachineData } from '../../types/vm';
 import { TEMPLATE } from '../../utils/const/index';
 import { ProvisionSource } from '../../utils/const/provisionSource';
 import { virtualization } from '../../views/virtualization';
 import { vm } from '../../views/vm';
 
-// const nic0: Network = {
-//  name: 'nic-0',
-//  nad: 'bridge-network',
-// };
+const nic0: Network = {
+ name: 'nic-0',
+ nad: 'bridge-network',
+};
 
 const urlVM: VirtualMachineData = {
  name: `url-vm-customize-wizard-${testName}`,
@@ -44,15 +44,16 @@ const pvcVM: VirtualMachineData = {
  startOnCreation: true,
 };
 
-// const pxeVM: VirtualMachineData = {
-// name: `pxe-vm-customize-wizard-${testName}`,
-// description: 'ID(CNV-771): create VM from PXE',
-// namespace: testName,
-// template: 'Fedora 32+ VM',
-// provisionSource: ProvisionSource.PXE,
-// sshEnable: false,
-// networkInterfaces: [nic0],
-// };
+const pxeVM: VirtualMachineData = {
+ name: `pxe-vm-customize-wizard-${testName}`,
+ description: 'ID(CNV-771): create VM from PXE',
+ namespace: testName,
+ template: TEMPLATE.FEDORA.name,
+ provisionSource: ProvisionSource.PXE,
+ sshEnable: false,
+ networkInterfaces: [nic0],
+ startOnCreation: false,
+};
 
 describe('Test VM creation', () => {
  before(() => {
@@ -94,4 +95,11 @@ describe('Test VM creation', () => {
  vm.customizeCreate(vmData);
  });
  });
+
+ it('ID(CNV-771): create VM from PXE', () => {
+ if (Cypress.env('DOWNSTREAM')) {
+ virtualization.vms.visit();
+ vm.customizeCreate(pxeVM);
+ }
+ });
 });
diff --git a/frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/vm/empty-state.spec.ts b/frontend/packages/kubevirt-plugin/integration-tests-cypress/tests/vm/empty-state.spec.ts
@@ -19,10 +19,13 @@ describe('ID(CNV-5654) test vm empty state', () => {
  virtualization.vms.visit();
  });
 
- // CI does not have quickstarts
- xit('Empty state has link to quick starts', () => {
- virtualization.vms.emptyState.clickQuickStarts();
- cy.get('.pf-c-search-input__text-input').should('have.value', 'virtual machine');
+ it('Empty state has link to quick starts', () => {
+ // CI does not have quickstarts
+ if (Cypress.env('DOWNSTREAM')) {
+ virtualization.vms.emptyState.clickQuickStarts();
+ // TODO: uncomment it once https://issues.redhat.com/browse/CNV-14013 is fixed.
+ // cy.get('.pf-c-search-input__text-input').should('have.value', 'virtual machine');
+ }
  });
 
  it('Empty state has action to create VM', () => {