Add name to coderef function.

Async component compares functions by name too.
jeremyary · Aug 10, 2021 · d567846 · d567846
1 parent 7ebe4ee
commit d567846
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/frontend/packages/console-dynamic-plugin-sdk/src/coderefs/coderef-resolver.ts b/frontend/packages/console-dynamic-plugin-sdk/src/coderefs/coderef-resolver.ts
@@ -93,9 +93,10 @@ export const resolveEncodedCodeRefs = (
 ): Extension[] =>
  _.cloneDeep(extensions).map((e) => {
  deepForOwn<EncodedCodeRef>(e.properties, isEncodedCodeRef, (ref, key, obj) => {
- obj[key] = applyCodeRefSymbol(async () =>
+ const loader = applyCodeRefSymbol(async () =>
  loadReferencedObject(ref, entryModule, pluginID, errorCallback),
  );
+ obj[key] = Object.defineProperty(loader, 'name', { value: `${pluginID}-${ref.$codeRef}` });
  });
 
  return e;

diff --git a/frontend/public/components/utils/async.tsx b/frontend/public/components/utils/async.tsx
@@ -8,7 +8,7 @@ import { LoadingBox } from './status-box';
  */
 const sameLoader = (a: () => Promise<React.ComponentType>) => (
  b: () => Promise<React.ComponentType>,
-) => (a || 'a').toString() === (b || 'b').toString();
+) => a?.name === b?.name && (a || 'a').toString() === (b || 'b').toString();
 
 enum AsyncComponentError {
  ComponentNotFound = 'COMPONENT_NOT_FOUND',