Fix commit 9f1e283 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add some tests so that I have an idea what was broken about the old implementation and I can make sure that your patch actually fixes it. |
|
https://github.com/daedric/jml/blob/9f1e283429ce3abeb986c4d55d673743810a47df/utils/json_parsing.h#L125-129 Where tests should be added ? |
|
Remi, it was my commit that broke it so I will write tests and incorporate the patch. Thanks @daedric for the contribution. |
Negative number were not handled properly. Reimplement the code using official json number parsing tree (http://www.json.org/)
|
You're welcome. I just updated the patch to handle in a better way the EOS |
|
BTW, I did not enforce the fact that a number can't start by a 0. If you want this test to be done, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative number were not handled properly. Reimplement the code using
official json number parsing tree (http://www.json.org/)