Rename variables used in the ExcCheck macros to avoid collisions #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAttab
added a commit
that referenced
this pull request
Sep 2, 2013
…cros Rename variables used in the ExcCheck macros to avoid collisions
jeremybarnes
added a commit
that referenced
this pull request
Jul 3, 2014
…t-erf Allow turning off boost erf (which crashes valgrind) (PLAT-568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs which are caused for example by a call like this:
Which would result to:
where
msgis interpreted as the local macro variable (which is now renamed to)msg__. This would cause a segfault, because the variable created in the macro hasn't been initialized at that point.