Merge pull request fetlife#144 from Seitk/fix/empty-features-crash-on…

…-multi-get Fix crash on multi_get when calling with empty features
jeromecornet · Nov 7, 2019 · bc7bd30 · bc7bd30
2 parents 99e5a81 + bc76bb4
commit bc7bd30
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/rollout.rb b/lib/rollout.rb
@@ -264,6 +264,8 @@ def clear_feature_data(feature)
  end
 
  def multi_get(*features)
+ return [] if features.empty?
+
  feature_keys = features.map { |feature| key(feature) }
  @storage.mget(*feature_keys).map.with_index { |string, index| Feature.new(features[index], string, @options) }
  end

diff --git a/spec/rollout_spec.rb b/spec/rollout_spec.rb
@@ -605,6 +605,12 @@
  expect(features[2].percentage).to eq 100
  expect(features.size).to eq 3
  end
+
+ describe 'when given feature keys is empty' do
+ it 'returns empty array' do
+ expect(@rollout.multi_get(*[])).to match_array([])
+ end
+ end
  end
 
  describe "#set_feature_data" do