keep the double quotes, but don't escape them

jerrycong · Jul 1, 2013 · a8cf5b8 · a8cf5b8
1 parent cdab4fa
commit a8cf5b8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/requests/cookies.py b/requests/cookies.py
@@ -261,7 +261,7 @@ def __delitem__(self, name):
 
  def set_cookie(self, cookie, *args, **kwargs):
  if cookie.value.startswith('"') and cookie.value.endswith('"'):
- cookie.value = cookie.value.strip('\\"')
+ cookie.value = cookie.value.replace('\\"', '')
  return super(RequestsCookieJar, self).set_cookie(cookie, *args, **kwargs)
 
  def update(self, other):

diff --git a/test_requests.py b/test_requests.py
@@ -173,7 +173,7 @@ def test_cookie_removed_on_expire(self):
  def test_cookie_quote_wrapped(self):
  s = requests.session()
  s.get(httpbin('cookies/set?foo="bar:baz"'))
- self.assertTrue(s.cookies['foo'] == 'bar:baz')
+ self.assertTrue(s.cookies['foo'] == '"bar:baz"')
 
  def test_request_cookie_overrides_session_cookie(self):
  s = requests.session()