Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deepvirfinder pip installable #14

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

papanikos
Copy link

Hello,

I wanted to make this available through conda eventually, started off with pip.

Current changes include

  • Restructure directories to conform to PyPA format.
  • Only code changes to the dvf.py script have been made. These include:
    • Automatic detection of the models dir, hoping it is useful when pip installed.
    • Dropped the optparse module in favor of argparse.
    • Minor refactoring to something more readable
    • Reporting on number of sequences and not lines (still with print statements)
    • The interface to dvf.py has changed to $ dvf.py -h (instead of $ python dvf.py -h)

If you agree with this, we should bump the version to 1.0.0 before merging- for now I used 0.9-beta for testing.

I tested this with python 3.6 and 3.7, seems ok.

For anyone interested, this worked for me on Ubuntu

$ conda create -n dvf_test python=3.6 # or 3.7
$ conda activate dvf_test
(dvf_test)$ pip install https://github.com/papanikos/DeepVirFinder/archive/v0.9-beta.tar.gz
(dvf_test)$ dvf.py -h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant