Feature/set jetkvm name #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added UI elements
device name appears on browser tab
jackislanding
changed the title
jackislanding
changed the title
|
Should this be filtered to DNS hostname validity? This way we could use this value for mDNS announcements. |
Sure, I can add a regex to filter the value |
|
Maybe we can use https://pkg.go.dev/github.com/asaskevich/govalidator?#IsDNSName |
|
what we could also do is having the device name and dns name as two separate fields, with automatically filled dns name with slugify. thus you can make mDNS happy without limiting your choice of names. |
|
That's a good idea, something like https://github.com/gosimple/slug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #83
Setting is moved under "Appearance" section
Device Name appears on browser tab
Reloading page loads device name again, since it is stored in settings store