ISSUE-221 Per request, upgrading dependency goja to v0.0.0-20230812105242-81d76064690d to include all ES6 features #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5242-81d76064690d to include all ES6 features This is a major upgrade for omniparser since the upgrade of goja requires go version 1.16, thus we're bumping omniparser min go version to 1.16 as well. Be careful when you upgrade omniparser.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 61 61
Lines 3368 3368
=======================================
Hits 3112 3112
Misses 248 248
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major upgrade for omniparser since the upgrade of goja requires go version 1.16, thus we're bumping omniparser min go version to 1.16 as well. Be careful when you upgrade omniparser.
#221