test: fix serviceWorker test flakiness (puppeteer#2195)

This patch starts waiting on serviceWorker registration.
jfmbrennan · Mar 15, 2018 · 4b7fbf8 · 4b7fbf8
1 parent 625c7eb
commit 4b7fbf8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/test/assets/serviceworkers/fetch/sw.html b/test/assets/serviceworkers/fetch/sw.html
@@ -1,4 +1,4 @@
 <link rel="stylesheet" href="./style.css">
 <script>
-  navigator.serviceWorker.register('sw.js');
+  window.registrationPromise = navigator.serviceWorker.register('sw.js');
 </script>
diff --git a/test/test.js b/test/test.js
@@ -2862,6 +2862,7 @@ describe('Page', function() {
 
       // Load and re-load to make sure serviceworker is installed and running.
       await page.goto(server.PREFIX + '/serviceworkers/fetch/sw.html', {waitUntil: 'networkidle2'});
+      await page.evaluate(async() => await window.registrationPromise);
       await page.reload();
 
       expect(responses.size).toBe(2);