Remove hardcoded user from Dockerfile #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the Dockerfile change in #111 to run the server as a non-root user by default, for two reasons:
Most users of the Docker image do not build the image themselves from the Dockerfile, so including a hardcoded UID/GID in the Docker image means they will always have to pass the
--userflag to override the hardcoded user to something specific to their system, or else open up file permissions. This came up in Permissions error #124.Using the debian-stable image to run the adduser command increases the image size by >10x.
As an alternative, I've updated the README doc with a recommendation to run the image with the --user flag.